I change the styling from html elements to css style and change the language value you mentioned.

I have tested this item ? unsuccessfully on 70ccd45

The removal begins and the contents of installation/src are removed and the a 500 error appears

@brianteeman i think i fixed your mentioned error.

@Schmidie64 Go to https://github.com/joomla/joomla-cms/pull/26276/files

and scroll down:

You will see the file is still deleted by your PR, the merge of the 4.0-dev branch into yours did not help. You have to explicitely add the file back in your branch, or if the file has been removed as the only action of one single commit, revert that one commit.

Now the robots.txt.dist is definitely inside my branch.

@Schmidie64 Correct, looks good now.
@C-Lodder Could you check if your remarks have been resolved, too?

@wilsonge It could be that the changes in this PR require also changes in system tests, file tests/Codeception/acceptance/install/InstallCest.php. At least drone log says installation with removal of the installation folder fails in mysql system test. Could you check that? Maybe it has other reasons than this PR?

Now the language string is also in the en-US Language file.

Correct system tests will need amending

Correct system tests will need amending

@wilsonge And that means? Amending by who and when? Now by author of this PR, or later by whomever? I ask because I have tested this PR now with success, but not sure if I shall give a good test result because the PR might break the system test. On the other hand I think we should not bother contributors with the tests if it is too comlicated. Please decide if my good test is valid or not.

The continuous-integration test is not failing because of this pr. In the file /administrator/components/com_finder/Indexer/Indexer.php is a phpdoc error but i don't think that this pr should fix this. Because it's a completely different part of Joomla.

this drone issues is biting us today more than legit and have nothing to do with this pr
the starting cause is my CS fault with this pr #25884 for which there is already a pr #26346
so simply ignore this "silly drone "

The current drone error is code style fixed by PR #26346 , I know that.

But yesterday or Sunday there was not this code style error but a system test which looked related. Am not good enough in system tests to judge that. Anyway, I am sure when I give good test result and it is wrong, George will tell us.

I have tested this item ✅ successfully on ac209a3

Test 1: As described in the instructions => OK, installation folder deleted with this PR and not deleted without this PR.
Test 2: Same as before, but in the confirmation dialog chosen "Cancel" => OK, installation folder not deleted.

Note that the system test has to be changed here https://github.com/joomla-projects/joomla-browser/blob/v4.0.0/src/JoomlaBrowser.php#L281 in order to reflect the change from a checkbox to a button and the new use of a browser message box. @wilsonge please protest if it was wrong to give a good test result.

https://github.com/joomla/joomla-cms/blob/4.0-dev/tests/Codeception/acceptance/install/InstallCest.php

@brianteeman Yes, I saw that, that's why I got curious about the tests.

I saw now the test is defined here: https://github.com/joomla-projects/joomla-browser/blob/develop/src/JoomlaBrowser.php#L350 https://github.com/joomla-projects/joomla-browser/blob/v4.0.0/src/JoomlaBrowser.php#L281. It seems at least the comment in that test is wrong because it already speaks about a button but seems to be older than this PR here.

Brian, what do you think? This PR is good as it is?

As @wilsonge said - the tests need to be fixed

@brianteeman Yes, I did read it, but it was not clear to me if someone shall do that later or if the author of this PR should do it, and if it is a requirement for giving this PR a good test. So I am really not sure if I could give it a good test like I did, or if I shouldn't have done that.

I have not tested this item.

Due to valid review comments by @Quy which require further changes I set back my test result to not tested. Later when review comments have been applied and it is clarified what to do with the system test I will test again.

Thanks!

@Schmidie64 Thanks for the nice button :-) I hope our reviews and all that have not been too much for you. But if there is something we could improve on that, let us know. You can e.g. get my website in my GitHub profile and there use the contact form if you have suggestions. I'll forward that to the JBS (Joomla Bug Squad) Team.

Thanks for your PR, and hope to see you contributing again from time to time. Ah and if nothing else to do and a bit bored: We always need testers for other PRs, it just needs to use Joomla for that ;-)