[#26275] - [4.0] metismenu upgrade
- Fixed in Code Base
- 25 Sep 2019
- Medium
- Build: 4.0-dev
- # 26275
- Diff
- brianteeman:metismenu
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Metismenu has been updated from 1.0.3 to 1.1.0
Unfortunately they didnt follow semver so this PR is to update our code to make sure the menu still works - specifically the open and closed submenu
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
@brianteeman Just looked at the plugin settings and here's what I saw:
This:
var ClassNames = {
activeClass: "active",
collapseClass: "collapse",
collapseInClass: "in",
collapsingClass: "collapsing"
}
was replaced with:
var ClassName = {
ACTIVE: "mm-active",
COLLAPSE: "mm-collapse",
COLLAPSED: "mm-collapsed",
COLLAPSING: "mm-collapsing",
METIS: "metismenu",
SHOW: "mm-show"
};
So there are other classes that need updating.
semver at it's finest
Is it not easier to set var ClassNames to match the current markup/js?
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration Templates (admin) JavaScript Repository NPM Change | ⇒ | Modules Administration Templates (admin) JavaScript Repository NPM Change |
Not going to lie and say I understand the changes I made and maybe I missed something but it seems to work
updated branch to trigger drone
Conflicts resolved
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26275.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26275.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26275.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26275.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-25 22:16:44 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Thanks
For reference the metismenu script was added here.. #22587