J4 Issue ?
avatar Scrabble96
Scrabble96
7 Sep 2019

What needs to be fixed

There is a 15px margin at the top of the first element in the component area. If there are left sidebar modules (whether there are right sidebars or not), then it is added to the top of the sidebar-left-container using the class .sidebar-left-container:

component-and-sidebar-left

component-and-both-sidebars

If there is no sidebar-left module, but a sidebar-right module, the margin is added to the top of component area with the class container-component:

component-and-sidebar-right

Why this should be fixed

It would be tidy

How would you fix it

Inspecting the code in Firefox shows that this code is the culprit:

.site-grid .container-header + div:not(.container-banner) { margin-top: 15px; }

Changing the margin to 0 does the trick:

component-sidebar-adjusted

I think this code is in (templates/cassiopeia/scss/blocks/_css-grid.scss) lines 64 to 71:

image
(sorry - that is an image. I don't know how to 'quote' from a file other than using the code tags in the editor.)

If that is the correct code, would it affect anything else if it was removed?

Side Effects expected

avatar Scrabble96 Scrabble96 - open - 7 Sep 2019
avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 Sep 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Sep 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 7 Sep 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Sep 2019
Status New Discussion
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Sep 2019

At https://community.joomla.org/gsoc-2019/gsoc-project-page-builder-third-coding-phase.html i read about:

Bildschirmfoto 2019-09-07 um 18 55 14

Maybe J4 comes with 2 Frontend-Templates?

avatar mbabker
mbabker - comment - 7 Sep 2019

Maybe J4 comes with 2 Frontend-Templates?

Oh please no. Has nobody learned over the last 10 years why shipping two templates for either application is a bad idea?

avatar astridx
astridx - comment - 7 Sep 2019

@Scrabble96 Here is an explanation how to insert a link to code: https://github.blog/2017-08-15-introducing-embedded-code-snippets/

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Sep 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-09-08 08:59:38
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Sep 2019

Closed as having Pull Request #26210

avatar franz-wohlkoenig franz-wohlkoenig - close - 8 Sep 2019
avatar Scrabble96
Scrabble96 - comment - 8 Sep 2019

@Scrabble96 Here is an explanation how to insert a link to code: https://github.blog/2017-08-15-introducing-embedded-code-snippets/

Many thanks, @astridx

avatar N6REJ
N6REJ - comment - 8 Sep 2019

@Scrabble96 I had the same problem using the "code" button in git. The solution is to use ``` preceding your code. If you follow that by the language used ( php css, etc ) its supposed to style it for you also.
Then paste in your text.

Add a Comment

Login with GitHub to post a comment