[#26202] - [4.0] Dont break com_config and the installer on update
- Closed
- 11 Jan 2020
- Medium
- Build: 4.0-dev
- # 26202
- Diff
- zero-24:dont_break_config_installer
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Dont break com_config and the installer on update
Testing Instructions
first test
- Install 4.0-alpha12-dev on windows
- confirm that com_config works (system -> Global configuration)
- conform that the installer code is still there as expected
- got to system -> Update -> Joomla -> Live Update
- reinstall core files
- notice that the installer code is gone
- notice that com_config is broken (windows systems only)
second test
- install a fresh copy of 4.0-alpha12-dev
- check that com_config works
- check installer code is still there
- update using this update server: https://www.jah-tz.de/downloads/core/com_config/com_config.xml
- notice com_config still works and the installer code is not removed
Expected result
Installer is still there & com_config is not broken
Actual result
installer is gone & com_config is broken on windows systems
Documentation Changes Required
none
Next steps
- [ ] set that folders to the blacklist in the build script https://github.com/joomla/joomla-cms/blob/staging/build/deleted_file_check.php
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
ok thanks just maked it as obsolte than :)
There needs to be a blacklist in my new script that i used to generate this however - because it's doing directory iterations https://github.com/joomla/joomla-cms/pull/25559/files
| Labels |
Added:
?
|
||
This is fine when updating between 4.0 versions. But not when upgrading from 3.x.
I experience this with J4 beta1-dev - after update folders are missing from com_config. A temporary solution is to copy com_config from an expanded package zip file.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26202.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-11 00:37:58 |
| Closed_By | ⇒ | wilsonge |
There shouldn't be a blacklist in that script. The entire intent is to write out a list of deleted files between any two git references. It's up to whomever is using the file that script generates to decide what to do with the data, which means reviewing it and not just copy/pasting the entire file into the com_admin script.