? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Aug 2019

pr for #26051

A can be seen in the screenshots below there are two different styles for counts

com_users groups

image

com_content categories

image

com_menus manage

image

Summary of Changes

banners->clients
smart search > maps
menus
tags
users > groups
workflows

Testing Instructions

most can be tested with patchtester but smart search maps has a css change so needs npm i

No bikeshedding

This PR is ONLY about consistency - anything else is off topic and will be ignored. (and hopefully deleted)

avatar brianteeman brianteeman - open - 29 Aug 2019
avatar brianteeman brianteeman - change - 29 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2019
Category Administration com_banners com_finder com_menus com_tags com_users com_workflow Templates (admin)
avatar brianteeman brianteeman - change - 29 Aug 2019
Labels Added: ?
avatar Quy Quy - test_item - 30 Aug 2019 - Tested successfully
avatar Quy
Quy - comment - 30 Aug 2019

I have tested this item successfully on 408891b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26066.

avatar amit4106udale amit4106udale - test_item - 19 Oct 2019 - Tested successfully
avatar amit4106udale
amit4106udale - comment - 19 Oct 2019

I have tested this item successfully on 408891b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26066.

avatar blueforce blueforce - test_item - 19 Oct 2019 - Tested successfully
avatar blueforce
blueforce - comment - 19 Oct 2019

I have tested this item successfully on 408891b

work as expected
tested with:
PHP-Version 7.3.8
Webserver Apache
PHP-Interface für den Webserver cgi-fcgi
Joomla!-Version Joomla! 4.0.0-alpha12-dev Development [ Amani ] 19-August-2019 13:40 GMT
Browsererkennung Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26066.

avatar Quy Quy - change - 19 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26066.

avatar idefax idefax - test_item - 19 Oct 2019 - Tested successfully
avatar idefax
idefax - comment - 19 Oct 2019

I have tested this item successfully on 408891b

Works!

PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26066.

avatar snehaM26 snehaM26 - test_item - 19 Oct 2019 - Tested successfully
avatar snehaM26
snehaM26 - comment - 19 Oct 2019

I have tested this item successfully on 408891b

Tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26066.

avatar HLeithner
HLeithner - comment - 19 Oct 2019

@brianteeman can you resolve the conflict, after that I can merge it. thx

avatar brianteeman brianteeman - change - 19 Oct 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 19 Oct 2019

@HLeithner conflicts resolved

avatar HLeithner HLeithner - change - 19 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-19 13:32:49
Closed_By HLeithner
avatar HLeithner HLeithner - close - 19 Oct 2019
avatar HLeithner HLeithner - merge - 19 Oct 2019
avatar HLeithner
HLeithner - comment - 19 Oct 2019

thx

avatar brianteeman
brianteeman - comment - 19 Oct 2019

Thanks.

Add a Comment

Login with GitHub to post a comment