? ?

Pending

User tests: Successful: Unsuccessful:

avatar ma-at
ma-at
29 Aug 2019

Pull Request for Issue # .

The or in the were clause will give a result for all users.

Summary of Changes

By putting it in parenthesis it will restrict to the user only.

Testing Instructions

If you search messages with a keyword I suppose you only search in your own messages. By the or in the were clause you also get results from other users.

Expected result

The search should give you only results from your own messages.

Actual result

results from all messages.

Documentation Changes Required

avatar ma-at ma-at - open - 29 Aug 2019
avatar ma-at ma-at - change - 29 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2019
Category Administration com_messages
avatar ma-at
ma-at - comment - 29 Aug 2019

This is my first pull request so not sure if I did it well

avatar alikon
alikon - comment - 29 Aug 2019

Hi @ma-at
to be a little bit more helpfull 😄
just fulfill the missing template points like :

  • Testing Instructions
  • Expected result
  • Actual result

it's a little bit hard to guess what you are trying to achieve.... or me i'm too naive

avatar ma-at ma-at - change - 29 Aug 2019
The description was changed
avatar ma-at ma-at - edited - 29 Aug 2019
avatar ma-at
ma-at - comment - 29 Aug 2019

Hi Nicola,

Not sure if it is clear now but I updated the template.
Just tell me if it is still confusing.

Op 29-08-19 om 12:13 schreef Nicola Galgano:

Hi @ma-at https://github.com/ma-at
to be a little bit more helpfull 😄
just fulfill the missing template points like :

  • Testing Instructions
  • Expected result
  • Actual result

it's a little bit hard to guess what you are trying to achieve.... or
me i'm too naive


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/26065?email_source=notifications&email_token=ADR7PIQMQWA6SYOMN3GGKBTQG6ONFA5CNFSM4ISALP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5N7PTY#issuecomment-526120911,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADR7PIUVPXUH6PV4AI5HZ6LQG6ONFANCNFSM4ISALP6A.

avatar ma-at ma-at - change - 29 Aug 2019
Labels Added: ?
avatar alikon
alikon - comment - 29 Aug 2019

thanks for the explanation,much more clear, now let's wait from some other's feedback , i'm not one of heavy user of that feature/use case

avatar SharkyKZ SharkyKZ - test_item - 18 Sep 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 18 Sep 2019

I have tested this item successfully on bf8e7ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26065.

avatar Quy Quy - test_item - 18 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 18 Sep 2019

I have tested this item successfully on bf8e7ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26065.

avatar Quy Quy - change - 18 Sep 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 Sep 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26065.

avatar HLeithner HLeithner - change - 28 Sep 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-28 15:00:33
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 28 Sep 2019
avatar HLeithner HLeithner - merge - 28 Sep 2019
avatar HLeithner
HLeithner - comment - 28 Sep 2019

Thanks for catching this bug.

Add a Comment

Login with GitHub to post a comment