? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Jul 2019

This PR changes the heading from h4 to h2 as there should be no "gaps" in the headings

This PR also changes the bootstrap accordion to the browser native Details/Summary element as used elsewhere.

Styling of this is beyond the scope of this PR
Other parts of com_privacy are beyond the scope of this PR

avatar brianteeman brianteeman - open - 29 Jul 2019
avatar brianteeman brianteeman - change - 29 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2019
Category Administration
avatar Quy
Quy - comment - 29 Jul 2019

Remove use Joomla\CMS\HTML\HTMLHelper;.

avatar brianteeman brianteeman - change - 29 Jul 2019
Labels Added: ?
avatar richard67
richard67 - comment - 29 Jul 2019

I have tested this item successfully on eb86171


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25740.

avatar richard67 richard67 - test_item - 29 Jul 2019 - Tested successfully
avatar Quy
Quy - comment - 30 Jul 2019

I have tested this item successfully on c06313b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25740.

avatar Quy Quy - test_item - 30 Jul 2019 - Tested successfully
avatar Quy Quy - change - 30 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25740.

avatar C-Lodder
C-Lodder - comment - 31 Jul 2019

Note that MS Edge does not support the Details/Summary elements (with the accordion effect). The content will always be visible.
Edge Chromium should be released in late 2019 (which will support it). Just something to think about.

avatar brianteeman
brianteeman - comment - 31 Jul 2019

polyfills are available for broken browsers https://github.com/javan/details-element-polyfill

avatar brianteeman brianteeman - change - 31 Jul 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 31 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-31 10:44:46
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 Jul 2019
avatar wilsonge wilsonge - merge - 31 Jul 2019
avatar wilsonge
wilsonge - comment - 31 Jul 2019

Thanks! Created an issue for the details/summary thing so it doesn't get forgotten #25749

avatar brianteeman
brianteeman - comment - 31 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment