? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
29 Jul 2019

Use a 3rd party library. @Hackwar was trying to remove the extra dependency. But it first failed the nightlies, then failed on windows

Rather than writing my own composer plugin I'm just assuming someone who's made the proper plugin knows better :)

avatar wilsonge wilsonge - open - 29 Jul 2019
avatar wilsonge wilsonge - change - 29 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2019
Category External Library Composer Change
avatar wilsonge wilsonge - change - 29 Jul 2019
The description was changed
avatar wilsonge wilsonge - edited - 29 Jul 2019
avatar wilsonge wilsonge - change - 29 Jul 2019
Labels Added: ? ?
avatar Hackwar
Hackwar - comment - 30 Jul 2019

The background was, that that extension also discovered our old codestyle in /build and that conflicted with the new styles in /libraries/vendor. For now that might be the better solution, yes, but I'd like to revisit that in the future.

avatar wilsonge wilsonge - change - 30 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-30 09:11:26
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Jul 2019
avatar wilsonge wilsonge - merge - 30 Jul 2019
avatar wilsonge
wilsonge - comment - 30 Jul 2019

Cool. Let's unblock the windows users then. Happy if you can come up with something better to look at it

Add a Comment

Login with GitHub to post a comment