? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
29 Jul 2019

Pull Request for Issue #25726 .

Summary of Changes

Checks that we're saving a plugin before continuing.

Testing Instructions

On a clean install try to install the "Testing Sample Data"

Expected result

Sample data completes all 8 steps successfully

Actual result

Sample data "hangs" after step 7 and console shows the following error

VM701:1 Uncaught SyntaxError: Unexpected token < in JSON at position 0
at JSON.parse ()
at onSuccess (sampledata-process.min.js?988a0f8a06606e444ef81cacee8fef3d:1)
at XMLHttpRequest.c.onreadystatechange (core.min.js?988a0f8a06606e444ef81cacee8fef3d:1)
onSuccess @ sampledata-process.min.js?988a0f8a06606e444ef81cacee8fef3d:1
c.onreadystatechange @ core.min.js?988a0f8a06606e444ef81cacee8fef3d:1
XMLHttpRequest.send (async)
a.request @ core.min.js?988a0f8a06606e444ef81cacee8fef3d:1
c.sampledataAjax @ sampledata-process.min.js?988a0f8a06606e444ef81cacee8fef3d:1
onSuccess @ sampledata-process.min.js?988a0f8a06606e444ef81cacee8fef3d:1
c.onreadystatechange @ core.min.js?988a0f8a06606e444ef81cacee8fef3d:1
XMLHttpRequest.send (async)
a.request @ core.min.js?988a0f8a06606e444ef81cacee8fef3d:1
c.sampledataAjax @ sampledata-process.min.js?988a0f8a06606e444ef81cacee8fef3d:1
onSuccess @ sampledata-process.min.js?988a0f8a06606e444ef81cacee8fef3d:1
c.onreadystatechange @ core.min.js?988a0f8a06606e444ef81cacee8fef3d:1
XMLHttpRequest.send (async)
a.request @ core.min.js?988a0f8a06606e444ef81cacee8fef3d:1
c.sampledataAjax @ sampledata-process.min.js?988a0f8a06606e444ef81cacee8fef3d:1
onSuccess @ sampledata-process.min.js?988a0f8a06606e444ef81cacee8fef3d:1
c.onreadystatechange @ core.min.js?988a0f8a06606e444ef81cacee8fef3d:1

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 29 Jul 2019
avatar SharkyKZ SharkyKZ - change - 29 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2019
Category Front End Plugins
avatar zero-24
zero-24 - comment - 29 Jul 2019

Looks good to me but please note that based on: #25716 (comment) the feature will be completly removed in the next days anyway.

avatar wilsonge wilsonge - change - 29 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-29 11:57:59
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 29 Jul 2019
avatar wilsonge wilsonge - merge - 29 Jul 2019

Add a Comment

Login with GitHub to post a comment