NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
14 Jul 2019

A few days ago the npm step of our Drone CI displayed messages that we should use browserslist to configure our browsers dependencies. This does that.

How to test?

Apply patch, run npm i and test if all scripts are still created correctly.

avatar Hackwar Hackwar - open - 14 Jul 2019
avatar Hackwar Hackwar - change - 14 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2019
Category JavaScript Repository NPM Change
avatar wilsonge
wilsonge - comment - 15 Jul 2019

@Hackwar you need to fix the js lint errors

avatar ghazal
ghazal - comment - 15 Jul 2019

I have tested this item successfully on 66fd3f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25557.

avatar ghazal ghazal - test_item - 15 Jul 2019 - Tested successfully
avatar Hackwar Hackwar - change - 15 Jul 2019
Labels Added: NPM Resource Changed ?
avatar Hackwar
Hackwar - comment - 26 Jul 2019

Fixed your remarks

avatar Hackwar
Hackwar - comment - 26 Jul 2019

So much for "fixed that". Still more to fix...

avatar Hackwar
Hackwar - comment - 26 Jul 2019

Seems like I found everything in the last commit. RTC?

avatar wilsonge wilsonge - change - 26 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-26 19:26:02
Closed_By wilsonge
avatar wilsonge wilsonge - close - 26 Jul 2019
avatar wilsonge wilsonge - merge - 26 Jul 2019
avatar wilsonge
wilsonge - comment - 26 Jul 2019

Thanks :)

Add a Comment

Login with GitHub to post a comment