? ? ? Success

User tests: Successful: Unsuccessful:

avatar pau1a
pau1a
14 Jul 2019

Pull Request for Issue #25343 .

Summary of Changes

Language string adjustments to provide consistency of user experience

Testing Instructions

Visit "Article - Global Options", view tooltips

Expected result

Consistent tooltips over "Show Publish Date","Show Modify Date","Show Create Date"

Actual result

As above

Documentation Changes Required

None

avatar pau1a pau1a - open - 14 Jul 2019
avatar pau1a pau1a - change - 14 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2019
Category Administration Language & Strings
avatar alikon
alikon - comment - 15 Jul 2019

@franz-wohlkoenig can you have a look, if it solve your issue #25343

avatar infograf768
infograf768 - comment - 15 Jul 2019

#25343 is describing also another issue
#25343 (comment)

We have this string 9 times in 8 different files (same for Publish and Created)

ROOT/administrator/components/com_content/config.xml:208: 			description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/administrator/components/com_content/models/forms/article.xml:467: 				description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/administrator/components/com_content/models/forms/article.xml:750: 				description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/archive/tmpl/default.xml:253: 				description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/article/tmpl/default.xml:198: 			description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/categories/tmpl/default.xml:616: 				description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/category/tmpl/blog.xml:534: 				description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/category/tmpl/default.xml:540: 				description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/featured/tmpl/default.xml:348: 				description="JGLOBAL_SHOW_MODIFY_DATE_DESC"

Therefore I am rather in favor of modiying
JGLOBAL_SHOW_CREATE_DATE_DESC
=> JGLOBAL_SHOW_MODIFY_DATE_DESC // NO need to change
JGLOBAL_SHOW_PUBLISH_DATE_DESC

to NOT include This is a global setting but can be changed at Menu and Article levels.

and create 3 new strings in administrator/language/en-GB/en-GB.com_content.ini
COM_CONTENT_SHOW_CREATE_DATE_DESC
COM_CONTENT_SHOW_MODIFY_DATE_DESC
COM_CONTENT_SHOW_PUBLISH_DATE_DESC

which would include This is a global setting but can be changed at Menu and Article levels.
and would replace the existing ones in config.xml

avatar brianteeman
brianteeman - comment - 15 Jul 2019

which would include This is a global setting but can be changed at Menu and Article levels.

Do we have this string on ALL settings where this would apply?

avatar infograf768
infograf768 - comment - 15 Jul 2019

Do we have this string on ALL settings where this would apply?

Indeed not.

Then the simplest solution is to simply delete This is a global setting but can be changed at Menu and Article levels. from
JGLOBAL_SHOW_CREATE_DATE_DESC
and
JGLOBAL_SHOW_PUBLISH_DATE_DESC

and we are done.

avatar brianteeman
brianteeman - comment - 15 Jul 2019

?

avatar infograf768
infograf768 - comment - 15 Jul 2019

But we also use this note in Config
COM_CONTENT_CONFIG_ARTICLE_SETTINGS_DESC="These settings apply for article layouts unless they are changed for a specific menu item."

which is incomplete as the settings also concern single articles.
Imho we should complete that.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Jul 2019

Tooltip for "Show Publish Date" talks about "(…) Category, Menu and Article levels" but on Category-Level it cannot be set.
60244552-eaac2500-98ba-11e9-88a7-53e3cefd6991

avatar infograf768
infograf768 - comment - 15 Jul 2019

@franz-wohlkoenig
Indeed. Another reason to take off this phrase from both strings and Update COM_CONTENT_CONFIG_ARTICLE_SETTINGS_DESC

@pau1a
Can you update this PR or shall I close and open a new PR with the changes above?

avatar pau1a
pau1a - comment - 15 Jul 2019

@infograf768 sure I will update this one

avatar pau1a pau1a - change - 15 Jul 2019
Labels Added: ? ?
avatar pau1a
pau1a - comment - 15 Jul 2019

But we also use this note in Config
COM_CONTENT_CONFIG_ARTICLE_SETTINGS_DESC="These settings apply for article layouts unless they are changed for a specific menu item."

which is incomplete as the settings also concern single articles.
Imho we should complete that.

How do we want this completed specifically?

avatar infograf768
infograf768 - comment - 15 Jul 2019

maybe
`COM_CONTENT_CONFIG_ARTICLE_SETTINGS_DESC="These settings apply for article layouts unless they are changed for a specific menu item or article."

avatar infograf768
infograf768 - comment - 16 Jul 2019

I have tested this item successfully on 142c98f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25556.

avatar infograf768 infograf768 - test_item - 16 Jul 2019 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jul 2019

I have tested this item successfully on 142c98f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25556.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 16 Jul 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jul 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jul 2019

Status "Ready To Commit".

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jul 2019

thanks for test @infograf768 and @pau1a for Screen Shot 2019-07-16 at 14 52 04 (if its true).

avatar pau1a
pau1a - comment - 16 Jul 2019

thanks for test @infograf768 and @pau1a for Screen Shot 2019-07-16 at 14 52 04 (if its true).

Yes its true. Thanks and glad to be involved. Hope to get more involved in the future :)

avatar infograf768 infograf768 - change - 16 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-16 12:57:04
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 16 Jul 2019
avatar infograf768 infograf768 - merge - 16 Jul 2019
avatar infograf768
infograf768 - comment - 16 Jul 2019

tks

avatar imanickam
imanickam - comment - 30 Jul 2019

Very minor point.

In the file [administrator/language/en-GB/en-GB.ini, in the following language string, why a SPACE has been added after the sentence completion?

- JGLOBAL_SHOW_MODIFY_DATE_DESC="If set to Show, the date and time an Article was last modified will be displayed."
+ JGLOBAL_SHOW_MODIFY_DATE_DESC="If set to Show, the date and time an Article was last modified will be displayed. "

My guess is that this language string was earlier modified to add the second sentence just like in the Create and Publish dates. Now that the second sentence will be shown as an informational message for the tab, there is no need to add the extra space in the above mentioned language string, unless I am missing something. The net result is that the language string mentioned will not get changed.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Jul 2019

@imanickam thanks for your Report. Can you please open a new Issue as comments on closed didn't get much Notice?

avatar infograf768
infograf768 - comment - 30 Jul 2019

Will directly make PR now.

avatar infograf768
infograf768 - comment - 30 Jul 2019

In fact, this has already been corrected. No need to patch.

avatar infograf768
infograf768 - comment - 30 Jul 2019

see
39b2ba7

Add a Comment

Login with GitHub to post a comment