User tests: Successful: Unsuccessful:
Pull Request for Issue #25343 .
Language string adjustments to provide consistency of user experience
Visit "Article - Global Options", view tooltips
Consistent tooltips over "Show Publish Date","Show Modify Date","Show Create Date"
As above
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings |
#25343 is describing also another issue
#25343 (comment)
We have this string 9 times in 8 different files (same for Publish and Created)
ROOT/administrator/components/com_content/config.xml:208: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/administrator/components/com_content/models/forms/article.xml:467: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/administrator/components/com_content/models/forms/article.xml:750: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/archive/tmpl/default.xml:253: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/article/tmpl/default.xml:198: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/categories/tmpl/default.xml:616: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/category/tmpl/blog.xml:534: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/category/tmpl/default.xml:540: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
ROOT/components/com_content/views/featured/tmpl/default.xml:348: description="JGLOBAL_SHOW_MODIFY_DATE_DESC"
Therefore I am rather in favor of modiying
JGLOBAL_SHOW_CREATE_DATE_DESC
=> JGLOBAL_SHOW_MODIFY_DATE_DESC // NO need to change
JGLOBAL_SHOW_PUBLISH_DATE_DESC
to NOT include This is a global setting but can be changed at Menu and Article levels.
and create 3 new strings in administrator/language/en-GB/en-GB.com_content.ini
COM_CONTENT_SHOW_CREATE_DATE_DESC
COM_CONTENT_SHOW_MODIFY_DATE_DESC
COM_CONTENT_SHOW_PUBLISH_DATE_DESC
which would include This is a global setting but can be changed at Menu and Article levels.
and would replace the existing ones in config.xml
which would include This is a global setting but can be changed at Menu and Article levels.
Do we have this string on ALL settings where this would apply?
Do we have this string on ALL settings where this would apply?
Indeed not.
Then the simplest solution is to simply delete This is a global setting but can be changed at Menu and Article levels.
from
JGLOBAL_SHOW_CREATE_DATE_DESC
and
JGLOBAL_SHOW_PUBLISH_DATE_DESC
and we are done.
But we also use this note in Config
COM_CONTENT_CONFIG_ARTICLE_SETTINGS_DESC="These settings apply for article layouts unless they are changed for a specific menu item."
which is incomplete as the settings also concern single articles.
Imho we should complete that.
@franz-wohlkoenig
Indeed. Another reason to take off this phrase from both strings and Update COM_CONTENT_CONFIG_ARTICLE_SETTINGS_DESC
@pau1a
Can you update this PR or shall I close and open a new PR with the changes above?
@infograf768 sure I will update this one
Labels |
Added:
?
?
|
But we also use this note in Config
COM_CONTENT_CONFIG_ARTICLE_SETTINGS_DESC="These settings apply for article layouts unless they are changed for a specific menu item."
which is incomplete as the settings also concern single articles.
Imho we should complete that.
How do we want this completed specifically?
maybe
`COM_CONTENT_CONFIG_ARTICLE_SETTINGS_DESC="These settings apply for article layouts unless they are changed for a specific menu item or article."
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
thanks for test @infograf768 and @pau1a for (if its true).
thanks for test @infograf768 and @pau1a for
(if its true).
Yes its true. Thanks and glad to be involved. Hope to get more involved in the future :)
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-16 12:57:04 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
tks
Very minor point.
In the file [administrator/language/en-GB/en-GB.ini, in the following language string, why a SPACE has been added after the sentence completion?
- JGLOBAL_SHOW_MODIFY_DATE_DESC="If set to Show, the date and time an Article was last modified will be displayed."
+ JGLOBAL_SHOW_MODIFY_DATE_DESC="If set to Show, the date and time an Article was last modified will be displayed. "
My guess is that this language string was earlier modified to add the second sentence just like in the Create and Publish dates. Now that the second sentence will be shown as an informational message for the tab, there is no need to add the extra space in the above mentioned language string, unless I am missing something. The net result is that the language string mentioned will not get changed.
@imanickam thanks for your Report. Can you please open a new Issue as comments on closed didn't get much Notice?
Will directly make PR now.
In fact, this has already been corrected. No need to patch.
@franz-wohlkoenig can you have a look, if it solve your issue #25343