[#25476] - [com_fields] Fix language strings/unknown columns/sorting
- Fixed in Code Base
- 11 Jul 2019
- Medium
- Build: staging
- # 25476
- Diff
- joomla:fields-language-strings
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Success continuous-integration/drone/push Build is passing Details
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Pending Hound Hound is busy sniffing around... Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fix language strings and columns.
Fix Field Group header not sorting.
Testing Instructions
Go to front end.
Edit an article.
Click on the Field button.
Right click on the modal to bring up a contextual menu to open This Frame > Open Frame in New Tab.
View the dropdown in the upper right corner.
Click on the Field Group header.
Go to back end.
Go to Content > Fields
Make sure there are fields assigned to field groups.
Click on Field Group header.
Click on Language header.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_fields |
I don't understand test step "Open the frame in a new tab.". You mean the modal for selecting the field? How shall I do that?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.
Updated testing instructions. Thanks.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.
Can you also change category_title to g.title to fix this:
Column not found: 1054 Unknown column 'category_title' in 'order clause'
Can you also change category_title to g.title to fix this:
Looks like we also need to take off category_title from here
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/models/fields.php#L47
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Category | Front End com_fields | ⇒ | Administration com_fields Front End |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.
Found another incongruity in backend Field modal when opening frame in new window. See Language at bottom of dropdown.
If I modify
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/views/fields/view.html.php#L207 to use a.language
and then in
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/views/fields/tmpl/modal.php#L60
same change.
I do get correctly
Let's solve also in this PR?
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.
In the frontext test I see untranslated language strings in the pull down.
I don't think it is related to this PR, but have you both @Quy and @infograf768 applied any other fix which I haven't applied yet? I've fetched clean staging just right now and made a fresh, clean install, and patch I applied with patchtester.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.
Restarted drone
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-11 08:00:30 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
tks
I don't understand test step "Open the frame in a new tab.". You mean the modal for selecting the field? How shall I do that?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25476.