? ? Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
8 Jul 2019

Pull Request for Issue #25467 .

Summary of Changes

Fix errors of sql files in administrator/components/com_admin/sql/updates/postgresql.
See the commit comments.

Testing Instructions

  1. Install a copy of Joomla 3.x (I was using 3.9.9 RC) on postgres
  2. Apply this PR to your joomla source directory.
  3. Build an update package to your joomla-4.0-dev source directory:
  • git tag 4.0.0-alpha11-dev
  • php build/build.php
  • Update Joomla 3.9.x with the new update package.
  1. Check if Joomla upgrades successfully

Expected result

No Warning or Error.

Actual result

Error
The template for this display is not available.

is going away.

database_check

Documentation Changes Required

avatar twister65 twister65 - open - 8 Jul 2019
avatar twister65 twister65 - change - 8 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jul 2019
Category Postgresql SQL Administration com_admin
avatar twister65 twister65 - change - 8 Jul 2019
Labels Added: ?
avatar richard67
richard67 - comment - 8 Jul 2019

For testers: You can find a modified nightly build from today 2019-07-08 morning with this PR applied here:
https://test5.richard-fath.de/Joomla_4.0.0-alpha11-dev-Development-Update_Package_2019-07-08_pr-25477.zip

avatar richard67 richard67 - test_item - 8 Jul 2019 - Tested successfully
avatar richard67
richard67 - comment - 8 Jul 2019

I have tested this item successfully on b60b991

Tested with the regular and my modified update package from today's nightly build, which I linked in my previous comment.

Regular update package: SQL errors, and the template not found warnings mentioned in issue #25467 don't go away.

Modified update package with this PR: No SQL errors, behavior like descibed in issue #25467, i.e. there are template not found warnings shown, but after update has finished, they go away and not appear again when navigating in the backend.

So this PR makes the update complete without crash. Without this PR update crashes because of SQL errors and so is not complete.

Other errors remain for updating 3.9.x to 4.0-dev, e.g. the menu entry for com_search is still there, but these are not subject of this PR. They shall (and I will do so) be reported in issue #25467 .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25477.

avatar twister65 twister65 - change - 9 Jul 2019
The description was changed
avatar twister65 twister65 - edited - 9 Jul 2019
avatar alikon
alikon - comment - 9 Jul 2019

I have tested this item successfully on b60b991


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25477.

avatar alikon alikon - test_item - 9 Jul 2019 - Tested successfully
avatar alikon alikon - change - 9 Jul 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 9 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25477.

avatar alikon
alikon - comment - 9 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25477.

avatar wilsonge wilsonge - change - 9 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-09 07:23:13
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 9 Jul 2019
avatar wilsonge wilsonge - merge - 9 Jul 2019
avatar wilsonge
wilsonge - comment - 9 Jul 2019

Thanks guys! Much appreciated :)

avatar wilsonge
wilsonge - comment - 9 Jul 2019

I've retriggered a nightly build of this so if any of you want to test using the nightly you can

Add a Comment

Login with GitHub to post a comment