[#25475] - [staging] Adding missing lang strings for XTD plugins
- Fixed in Code Base
- 12 Jul 2019
- Medium
- Build: staging
- # 25475
- Diff
- infograf768:missingsortstrings
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25344
Replaces #25472
Summary of Changes
Loading main administrator joomla xx-XX.ini is not a good idea as it may override some frontend xx-XX.ini strings.
The only reason $lang->load('joomla', JPATH_ADMINISTRATOR); was added for com_menus and com_modules was to get these strings from backend.
These calls are now deleted.
The correct solution was to add then in frontend.
Some looks weird to add:
JTOGGLE_HIDE_SIDEBAR="Hide the sidebar"
JTOGGLE_SHOW_SIDEBAR="Show the sidebar"
but as they show as untranslated when using the Field xtd, I added them.
(it would be interesting to find out why they are needed there and if corrected, delete them in 4.0)
Testing Instructions
Set Language debug on and load each xtd plugin when editing an article in frontend.
Check if any string is missing.
After patch
The main display change with Protostar is the corrected JGLOBAL_LIST_ALIAS="(<span>Alias</span>: %s)" string.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_modules Language & Strings |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475.
| Category | Front End com_modules Language & Strings | ⇒ | Administration com_fields Front End com_modules Language & Strings |
@Quy
Please test again. I found out why
JTOGGLE_HIDE_SIDEBAR
JTOGGLE_SHOW_SIDEBAR
was showing as untranslated for the Field xtd plugin.
Sidebar was also loaded for modal which should not have been done. :)
Therefore corrected the view.html.php and took off the strings from frontend.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475.
@HLeithner
Please merge so that TTs can work on it asap.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-12 07:50:50 |
| Closed_By | ⇒ | HLeithner |
thx
@Quy Should be OK now. tks.