[#25398] - Subform - Wrong ID generated for the elements of subform when we click on Plus (+) button to add repeated subform #25387
- Fixed in Code Base
- 2 Jul 2019
- Medium
- Build: staging
- # 25398
- Diff
- cheetabhai:staging
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25387
Summary of Changes
The value of id attribute of input element is checked for non-word characters and if non-word characters are found then replacing with them with underscore
Testing Instructions
Check the value of id attribute of input element in repetable subform after clicking the plus (+) button to add new clone of sub-form
Expected result
The value of id attribute of input element should not contain any non-word character
Actual result
The non-word characters in the value of id attribute of input element are being replaced with underscore
Documentation Changes Required
no change required in documentation
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
Now you need to generate a minified file (media/system/js/subform-repeatable.js).
updated the related minified js file
Is manually modified minified file fine in this case?
as of now I have manually modified the minified JS
@crystalenka @ankush-maherwal please test (how to: https://docs.joomla.org/Testing_Joomla!_patches)
I have tested this item
Solves both issues #25387 and #25384 .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25398.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-02 16:52:40 |
| Closed_By | ⇒ | HLeithner |
thx
@ankush-maherwal please test (how to: https://docs.joomla.org/Testing_Joomla!_patches)