Feeling Lucky
?
?
[#25397] - [4.0] Unused code after #24025
- Fixed in Code Base
- 2 Jul 2019
- Medium
- Build: 4.0-dev
- # 25397
- Diff
- brianteeman:unused_pront
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
It seems that I removed one instance of this code for a print button but missed another one under a different condition. This code can not do anything because of #24025 and I should have removed it then. This PR fixes my error
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
SharkyKZ
- comment
- 2 Jul 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25397.
SharkyKZ
- comment
- 2 Jul 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25397.
SharkyKZ
- comment
- 2 Jul 2019
Joomla\Component\Content\Site\View\Article::$print and Joomla\Component\Newsfeeds\Site\View\Newsfeed::$print properties should be deprecated or removed.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 2 Jul 2019
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-02 22:54:27 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 2 Jul 2019
Thanks! Also @brianteeman can you look into @SharkyKZ 's comment please
I have tested this item✅ successfully on 73522a1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25397.