? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Jul 2019

Unlike with a physical keyboard a mobile or touch device has multiple different keyboards. This PR ensures that joomla uses the correct mobile keyboard which greatly increases usability on mobile/touch. Although support is not 100% on desktop touchscreen browsers it is really mainly for devices with no physical keyboards

This PR adds an attribute as appropriate inputmode="xxxxxx" for the field types url, tel, number and email.

This can be tested on any mobile/touch device.

Android screenshots below. iOS is a little different with some extra keys

Url (/) key

Screenshot_20190701-161939

Email (@) key

Screenshot_20190701-161822

Number

Screenshot_20190701-162115

Tel (not used in core)

Screenshot_20190701-162031

avatar brianteeman brianteeman - open - 1 Jul 2019
avatar brianteeman brianteeman - change - 1 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2019
Category Layout
avatar brianteeman brianteeman - change - 1 Jul 2019
The description was changed
avatar brianteeman brianteeman - edited - 1 Jul 2019
avatar HLeithner
HLeithner - comment - 1 Jul 2019

I would suggest to add this to the JFormField XML specification.

c37493c 1 Jul 2019 avatar brianteeman oops
avatar brianteeman brianteeman - change - 1 Jul 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 1 Jul 2019

I would suggest to add this to the JFormField XML specification.

Why? This is a layout change - nothing to do with the XML

avatar HLeithner
HLeithner - comment - 1 Jul 2019

Not for the default but override able, for example you have a search field and would like to create a JFormInput and set the inputmode to "search".

avatar brianteeman
brianteeman - comment - 1 Jul 2019

In that example I would add the inputmode to the text field in the search module. This PR is only for the field input types url, tel, number and email anything else is completely beyond the scope. I can't think of any scenario where you would want to disable/change/override these 4 inputmodes.

avatar HLeithner
HLeithner - comment - 1 Jul 2019

number could be decimal for example, tel could be a voip number (with enum which looks like a hostname)... there are cases maybe not today but having this feature in core wouldn't be an error.

avatar brianteeman
brianteeman - comment - 1 Jul 2019

Feel free to submit it as a new feature the. It's not something I am remotely interested in doing. All your use case example are already addressed.

avatar wilsonge wilsonge - change - 1 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-01 20:12:26
Closed_By wilsonge
avatar wilsonge wilsonge - close - 1 Jul 2019
avatar wilsonge wilsonge - merge - 1 Jul 2019
avatar wilsonge
wilsonge - comment - 1 Jul 2019

This makes sense to me as it is. I agree with you though @HLeithner making it dynamic for at least the text field would also seem sensible

avatar brianteeman
brianteeman - comment - 1 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment