? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
1 Jul 2019

Pull Request for Issue #25388.

Summary of Changes

Removes incorrect table prefix.

Testing Instructions

Code review or install older alpha version. Trigger update notification plugin.

Expected result

No errors.

Actual result

Call to a member function getRootId() on bool

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 1 Jul 2019
avatar SharkyKZ SharkyKZ - change - 1 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2019
Category Front End Plugins
avatar SharkyKZ SharkyKZ - change - 2 Jul 2019
Labels Added: ?
avatar sakiss
sakiss - comment - 2 Jul 2019

I have tested this item successfully on 890233a

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Jul 2019
avatar Quy
Quy - comment - 2 Jul 2019

I got different errors under Components > Joomla! Update.

Notice: Undefined property: Joomla\CMS\Updater\Update::$downloadurl in \administrator\components\com_joomlaupdate\tmpl\joomlaupdate\default_update.php on line 49

Notice: Trying to get property '_data' of non-object in \administrator\components\com_joomlaupdate\tmpl\joomlaupdate\default_update.php on line 49

avatar richard67
richard67 - comment - 2 Jul 2019

And I could not reproduce issue #25388 for the real test.

avatar SharkyKZ
SharkyKZ - comment - 3 Jul 2019

@Quy issue unrelated to this PR.

@richard67 Hm, I can't either. Updates are not found so the erroneous code is not triggered. Which version did you use?

avatar SharkyKZ
SharkyKZ - comment - 3 Jul 2019

PR #25412 for removing hardcoded ID from the plugin. But that won't help testing this on older versions.

avatar sakiss
sakiss - comment - 3 Jul 2019

@richard67 @Quy You need to have an older version (e.g. alpha 8) and have configured the Joomla Update component to perform automatic updates, based on the update stream given for J4.

The error is generated once a new version is found.

avatar sakiss
sakiss - comment - 3 Jul 2019

@SharkyKZ Though your PR does not solve the problem in the first place, since Table::getInstance(), returns Table or boolean. In the 2n case the call of getRootId() is invalid

avatar SharkyKZ
SharkyKZ - comment - 3 Jul 2019

@sakiss are you still getting the error? Joomla\CMS\Table\Table::getInstance() returns false only when the table class is not found. It's not found before patch because incorrect prefix is passed. After patch it should always be found (it's a core table).

avatar laoneo laoneo - close - 12 Feb 2020
avatar laoneo laoneo - merge - 12 Feb 2020
avatar laoneo laoneo - change - 12 Feb 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-12 08:13:28
Closed_By laoneo
avatar laoneo
laoneo - comment - 12 Feb 2020

Thanks!

Add a Comment

Login with GitHub to post a comment