J4 Issue ?
avatar sakiss
sakiss
1 Jul 2019

Steps to reproduce the issue

I am getting this fatal error on the admin login page. Seems like it came around once a new version is released.
*I set my admin to find J4 updates from the update stream

Expected result

Admin login form

Actual result

Error page

System information (as much as possible)

Joomla 4.0 alpha 8

Additional comments

Call stack

| Function | Location

1 | () | JROOT/plugins/system/updatenotification/updatenotification.php:331
2 | PlgSystemUpdatenotification->getSuperUsers() | JROOT/plugins/system/updatenotification/updatenotification.php:210
3 | PlgSystemUpdatenotification->onAfterRender() | JROOT/libraries/src/Plugin/CMSPlugin.php:285
4 | Joomla\CMS\Plugin\CMSPlugin->Joomla\CMS\Plugin{closure}() | JROOT/libraries/vendor/joomla/event/src/Dispatcher.php:412
5 | Joomla\Event\Dispatcher->dispatch() | JROOT/libraries/src/Application/EventAware.php:111
6 | Joomla\CMS\Application\WebApplication->triggerEvent() | JROOT/libraries/src/Application/CMSApplication.php:976
7 | Joomla\CMS\Application\CMSApplication->render() | JROOT/libraries/src/Application/AdministratorApplication.php:450
8 | Joomla\CMS\Application\AdministratorApplication->render() | JROOT/libraries/src/Application/CMSApplication.php:247
9 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/administrator/includes/app.php:63
10 | require_once() | JROOT/administrator/index.php:36

avatar sakiss sakiss - open - 1 Jul 2019
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Jul 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Jul 2019

Nightly Builds cannot be updated in Alpha. Please install a fresh Build.

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Jul 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-07-01 12:36:57
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - close - 1 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Jul 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 1 Jul 2019
avatar sakiss
sakiss - comment - 1 Jul 2019
  1. Nightly Builds cannot be updated in Alpha. Please install a fresh Build.

Then the Nightly Builds page should be updated as it suggests an update stream for the J4 alphas.
https://developer.joomla.org/nightly-builds.html
Btw. This stream was working perfectly updating all the previous J4 alphas

  1. Still this does not solve the error in the first place.
    There is an error in the plugins/system/updatenotification plugin which should be fixed or at least handled.
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Jul 2019
Status Closed New
Closed_Date 2019-07-01 12:36:57
Closed_By franz-wohlkoenig
avatar franz-wohlkoenig franz-wohlkoenig - reopen - 1 Jul 2019
avatar sakiss
sakiss - comment - 1 Jul 2019

The error comes from this code:
Table::getInstance('Asset', 'Table')->getRootId();

Table::getInstance() returns a Table object or false (when it fails).
Trying to call getRootId() from a boolean causes a fatal error.

Possibly some type check should be preceded.

$table=Table::getInstance('Asset', 'Table');
if($table===false) {
return $ret;
}
$rootId=$table->getRootId();
avatar SharkyKZ
SharkyKZ - comment - 1 Jul 2019

Test PR #25390 please.

avatar Quy Quy - edited - 1 Jul 2019
avatar Quy Quy - close - 1 Jul 2019
avatar Quy Quy - change - 1 Jul 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-07-01 17:28:41
Closed_By Quy
avatar sakiss
sakiss - comment - 2 Jul 2019

PR #25390 fixes it

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Jul 2019

Add a Comment

Login with GitHub to post a comment