Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25363] - [4.0] Changelogurl: modify conditional

? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
29 Jun 2019

Pull Request for Issue #25311 (comment)

Summary of Changes

Mofifying conditional as it is preferred

Testing Instructions

See #2531
The result should be the same.

@hgh-esn @wilsonge

avatar infograf768 infograf768 - open - 29 Jun 2019
avatar infograf768 infograf768 - change - 29 Jun 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2019
Category ⇒ Administration com_installer
avatar hgh-esn
hgh-esn - comment - 29 Jun 2019

we also should change the <?php if ($item->version !== '') : ?> to if (!emtly($item->version)) : ?>` or better delete the whole statement

<?php if ($item->version !== '') : ?>`
........ **this code must stay !**
<?php else :
     echo '&#160;';
endif; ?>

because we do not do anything with $item->version except that we display its value.

avatar infograf768
infograf768 - comment - 29 Jun 2019

version is out of this scope. It works fine as is. If you are not happy with that please propose a new PR where the decision can be taken to modify or not. I do not see the need for it personally (The version should be displayed even if there is no changelog url)

Therefore please test this PR which is limited to changelogurl following the discussion we had formerly.

avatar richard67 richard67 - test_item - 29 Jun 2019 - Tested successfully
avatar richard67
richard67 - comment - 29 Jun 2019

I have tested this item ✅ successfully on 6d9ca8d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25363.

avatar richard67
richard67 - comment - 29 Jun 2019

I have tested this item ✅ successfully on 6d9ca8d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25363.

avatar wilsonge wilsonge - change - 29 Jun 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-06-29 09:42:28
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 29 Jun 2019
avatar wilsonge wilsonge - merge - 29 Jun 2019
avatar wilsonge
wilsonge - comment - 29 Jun 2019

Thanks!

avatar hgh-esn hgh-esn - test_item - 29 Jun 2019 - Tested successfully
avatar hgh-esn
hgh-esn - comment - 29 Jun 2019

I have tested this item ✅ successfully on 6d9ca8d

It works as expected.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25363.

Add a Comment

Login with GitHub to post a comment