? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jun 2019

Pull Request for Issue #16788 ....same as #24675 for contacts - I really just copied the work of others (someone has to)

Summary of Changes

some datetime fields should be nullable as default

  • publish_up
  • publish_down
  • checked_out_time

Testing Instructions

test com_newsfeeds

Expected result

newsfeeds should works as before

322faf5 28 Jun 2019 avatar brianteeman sql
avatar brianteeman brianteeman - open - 28 Jun 2019
avatar brianteeman brianteeman - change - 28 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jun 2019
Category SQL Administration com_admin Postgresql com_newsfeeds Front End Installation
avatar tonypartridge
tonypartridge - comment - 13 Jul 2019

@brianteeman please review Quy's changes and ill test

avatar brianteeman brianteeman - change - 13 Jul 2019
Labels Added: ?
80f93cf 13 Jul 2019 avatar brianteeman cs
avatar brianteeman
brianteeman - comment - 13 Jul 2019

codestyle should be ok now

avatar Quy
Quy - comment - 23 Jul 2019

I have tested this item successfully on 5f0f6ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25362.

avatar Quy Quy - test_item - 23 Jul 2019 - Tested successfully
avatar alikon
alikon - comment - 23 Jul 2019

I have tested this item successfully on 5f0f6ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25362.

avatar alikon alikon - test_item - 23 Jul 2019 - Tested successfully
avatar alikon alikon - change - 23 Jul 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 23 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25362.

avatar joomla-cms-bot joomla-cms-bot - edited - 23 Jul 2019
avatar wilsonge wilsonge - change - 23 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-23 17:54:52
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Jul 2019
avatar wilsonge wilsonge - merge - 23 Jul 2019
avatar wilsonge
wilsonge - comment - 23 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 23 Jul 2019

thanks

Add a Comment

Login with GitHub to post a comment