Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25333] - [4.0] Fix Codemirror fullscreen

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
26 Jun 2019

Pull Request for Issue #24530

Summary of Changes

Fix the fullscreen mode in Codemirror, by hiding the header and adjusting the top position.

Testing Instructions

  • Set codemirror as your editor
  • Open any article
  • Press F10 or CTRL+Q to enable fullscreen mode
  • Press F10 or CTRL+Q or ESC to close fullscreen
avatar C-Lodder C-Lodder - open - 26 Jun 2019
avatar C-Lodder C-Lodder - change - 26 Jun 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jun 2019
Category ⇒ Administration Templates (admin) JavaScript Repository NPM Change
avatar C-Lodder C-Lodder - change - 26 Jun 2019
Labels Added: NPM Resource Changed ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Jun 2019

@rotimi-best please test (how to: https://docs.joomla.org/Testing_Joomla!_patches)

avatar Quy Quy - test_item - 26 Jun 2019 - Tested successfully
avatar Quy
Quy - comment - 26 Jun 2019

I have tested this item ✅ successfully on a7e8581

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25333.

avatar wilsonge wilsonge - close - 3 Jul 2019
avatar wilsonge wilsonge - merge - 3 Jul 2019
avatar wilsonge wilsonge - change - 3 Jul 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-07-03 15:49:04
Closed_By ⇒ wilsonge
avatar wilsonge
wilsonge - comment - 3 Jul 2019

Thanks!

Add a Comment

Login with GitHub to post a comment