Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25332] - [4.0] Update dependencies

NPM Resource Changed ? Success

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
26 Jun 2019

Summary of Changes

Update dependencies

Note that this really should be automated by a Bot. Consider using Renovate or dependabot-preview

Testing Instructions

Go round the site and ensure it's working the same as before

avatar C-Lodder C-Lodder - open - 26 Jun 2019
avatar C-Lodder C-Lodder - change - 26 Jun 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jun 2019
Category ⇒ NPM Change Front End Plugins
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Jun 2019

Note that this really should be automated by a Bot. Consider using Renovate or dependabot-preview

added this for Meeting of BugSquadTeam this Friday.

avatar wilsonge
wilsonge - comment - 26 Jun 2019

@C-Lodder you need to commit a package-lock to go with this otherwise we won't get the new deps

avatar C-Lodder C-Lodder - change - 26 Jun 2019
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jun 2019
Category NPM Change Front End Plugins ⇒ Administration com_media NPM Change Front End Plugins
avatar wilsonge
wilsonge - comment - 26 Jun 2019

@C-Lodder still wrong. package-lock.json has tinymce still at version 5.0.1 for example. whereas in this pr you're trying to bump it to 5.0.9. You need to run npm update not just npm install

avatar C-Lodder
C-Lodder - comment - 26 Jun 2019

@wilsonge done. Has to revert babel-preset-minify back to 0.4.3 as the later version was causing issues

avatar wilsonge
wilsonge - comment - 27 Jun 2019

Javscript tests are still failing

avatar C-Lodder C-Lodder - change - 2 Jul 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-07-02 14:46:42
Closed_By ⇒ C-Lodder
avatar C-Lodder C-Lodder - close - 2 Jul 2019

Add a Comment

Login with GitHub to post a comment