[#25238] - [4.0] Fix installer plugin detection
- Fixed in Code Base
- 23 Jun 2019
- Medium
- Build: 4.0-dev
- # 25238
- Diff
- Quy:patch-6
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Redo PR #21262.
Summary of Changes
Fix notice when no installer plugins.
Testing Instructions
Under Manage > Plugins, search Installer - Install.
Disable 4 plugins.
Go to System > Install > Extensions.
See notice.
Install PR.
No more notice.
Actual result
Notice: Undefined offset: 0 in \administrator\components\com_installer\tmpl\install\default.php on line 43
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
Do we need to render the tabset when no tabs are present?
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25238.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25238.
| Status | Pending | ⇒ | Ready to Commit |
rtc
Not sure what you mean.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25238.
rtc
Not sure what you mean.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25238.
@infograf768 an empty tab set is rendered if all plugins are disabled. Maybe it's fine, not a big deal.
| Labels |
Added:
?
|
||
Just wrapping the tab set with $tabs check alone would fix the notice. But it's fine either way.
The following will have to be addressed $this->ftp and uitab.endTabSet. Ideally is to hide the entire <div id="installer-install" class="clearfix">.
The reason I've been holding on these PR's (i'm pretty sure it's not the only version of this hanging around) is because we shouldn't just delete plugin events. I'm not sure exactly what's changed to make this suddenly an issue in j4 when it wasn't in j3. But I'm pretty sure removing onInstallerViewBeforeFirstTab and onInstallerViewAfterLastTab can't be the correct solution for it
The events aren't an issue here. But they're not needed in J4. This is to do with IFW plugin. IFW 1.x used these events to decide tab order. In J4/IFW 2.0 we can just use plugin ordering. That already works in J3/IFW 2.0 but events can't be removed in J3.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-23 08:19:53 |
| Closed_By | ⇒ | roland-d |
Thank you.
I have tested this item✅ successfully on f529843
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25238.