Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25239] - [4.0] "back-to-top": Structural flaw in the footer tag of Cassiopeia

? ?
avatar ghazal
ghazal
16 Jun 2019

There is a structural flaw in the footer tag of the site template:

<footer class="grid-child container-footer footer">
	<hr>
	<p class="float-right">
		<a href="#top" id="back-top" class="back-top">
			<span class="icon-arrow-up-4" aria-hidden="true"></span>
			<span class="sr-only"><?php echo Text::_('TPL_CASSIOPEIA_BACKTOTOP'); ?></span>
			</a>
		</p>
<jdoc:include type="modules" name="footer" style="none" />
	</footer>

Actual result

The "back-to-top" feature is in the same tag as a call to a module in a footer position. So, when one assigns a module to the footer position, the module content is kind of "glued" to the "back-to-top".
I guess the call to the module should be at least in another tag, maybe another footer.

avatar ghazal ghazal - open - 16 Jun 2019
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Jun 2019
avatar Quy
Quy - comment - 16 Jun 2019

Duplicate of Issue #23457 and its PR #23606?

avatar C-Lodder
C-Lodder - comment - 16 Jun 2019

@Quy, the PR isn't a good approach at all. The "back to top" should be a custom module so that users can disable it if required

avatar Quy
Quy - comment - 16 Jun 2019

Closed PR #23606 for a proper fix.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jun 2019
Status New ⇒ Discussion
avatar SharkyKZ
SharkyKZ - comment - 17 Jun 2019

"Back to top" It's fine as a template feature, IMO. But a template option could be added for disabling it.

avatar C-Lodder
C-Lodder - comment - 17 Jun 2019

PR: #25250

avatar joomla-cms-bot joomla-cms-bot - close - 17 Jun 2019
avatar alikon alikon - change - 17 Jun 2019
Status Discussion ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-06-17 08:34:33
Closed_By ⇒ alikon
avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Jun 2019

Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/25239

avatar alikon
alikon - comment - 17 Jun 2019

closed for pr #25250

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25239.

avatar C-Lodder
C-Lodder - comment - 15 Jul 2019

@alikon PR closed. This can be reopened.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jul 2019
Status Closed ⇒ New
Closed_Date 2019-06-17 08:34:33 ⇒
Closed_By alikon ⇒
avatar joomla-cms-bot joomla-cms-bot - reopen - 15 Jul 2019
avatar alikon alikon - change - 15 Jul 2019
Status New ⇒ Discussion
Closed_Date 0000-00-00 00:00:00 ⇒
avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Jul 2019

Set to "open" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/25239

avatar alikon
alikon - comment - 15 Jul 2019

reopened as requested

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25239.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Jul 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 19 Jul 2019
avatar Scrabble96
Scrabble96 - comment - 7 Sep 2019

Can this issue be renamed to include "back-to-top" or "back-top" as that is what this is really about?

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Sep 2019
Title
…
[4.0] Structural flaw in the footer tag of Cassiopeia
[4.0] "back-to-top": Structural flaw in the footer tag of Cassiopeia
avatar franz-wohlkoenig franz-wohlkoenig - edited - 7 Sep 2019
avatar Quy Quy - change - 9 Aug 2020
Labels Added: ?
Removed: J4 Issue
avatar Quy Quy - unlabeled - 9 Aug 2020
avatar Quy Quy - labeled - 9 Aug 2020
avatar richard67 richard67 - change - 21 Aug 2020
Status Discussion ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-08-21 12:59:18
Closed_By ⇒ richard67
avatar richard67 richard67 - close - 21 Aug 2020
avatar richard67
richard67 - comment - 21 Aug 2020

Closing as having a pull request (PR) which shall solve this issue. Please test PR #30441 .

Add a Comment

Login with GitHub to post a comment