? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jun 2019

The fields used for creating/editing/selecting an article etc in the menu manager have title attributes that are not needed. They don't add anything for accessibility.

image

avatar brianteeman brianteeman - open - 16 Jun 2019
avatar brianteeman brianteeman - change - 16 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2019
Category Administration com_categories com_contact com_content com_menus com_newsfeeds
avatar Quy
Quy - comment - 16 Jun 2019

I have tested this item successfully on afdb97e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25233.

avatar Quy Quy - test_item - 16 Jun 2019 - Tested successfully
avatar richard67
richard67 - comment - 16 Jun 2019

I have tested this item successfully on afdb97e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25233.

avatar richard67 richard67 - test_item - 16 Jun 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jun 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2019

Status "Ready To Commit".

avatar brianteeman
brianteeman - comment - 17 Jun 2019

@franz-wohlkoenig could you put the 4.0 label back please.

avatar brianteeman brianteeman - change - 17 Jun 2019
Labels Added: ?
avatar zero-24
zero-24 - comment - 17 Jun 2019

@brianteeman the branch label is done by the tracker no manual interaction required ;)

avatar brianteeman
brianteeman - comment - 17 Jun 2019

@zero-24 I know but for some reason he removed it
image

Updating the branch triggered the bot again ;)

avatar zero-24
zero-24 - comment - 17 Jun 2019

Yes when the PR is set faster to RTC (or any other change) than the bot syncs the labels this can happen.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jun 2019

Changing Status from "Pending" > "RTC" in Issue Tracker removes this Label.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jun 2019

PR is set faster to RTC

@zero-24 means if i wait longer to save this label-thing didn't happen?

avatar zero-24
zero-24 - comment - 17 Jun 2019

@zero-24 means if i wait longer to save this label-thing didn't happen?

Yes. I have just done a PR that you can see that label and milestone option too: joomla/jissues#1062

avatar brianteeman brianteeman - change - 18 Jun 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-19 06:29:50
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Jun 2019
avatar wilsonge wilsonge - merge - 19 Jun 2019
avatar wilsonge
wilsonge - comment - 19 Jun 2019

Thanks!

avatar brianteeman
brianteeman - comment - 19 Jun 2019

Thanks

Add a Comment

Login with GitHub to post a comment