[#25234] - Appeasing Appveyor
- Closed
- 16 Jun 2019
- Medium
- Build: staging
- # 25234
- Diff
- Hackwar:patch-9
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Hopefully makeing Appveyor happy again.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries Composer Change |
It seems before making Appveyor happy it needs to wake him up.
Hooray, appveyor passed with success!!!
I have tested this item
Before this PR, Appveyor tests failed here:
https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/string/src/phputf8/utf8.php#L38
with error
Warning: A non-numeric value encountered in C:\projects\joomla-cms\libraries\vendor\joomla\string\src\phputf8\utf8.php on line 38
With this PR is passes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25234.
@zero-24 PR for framwork package see joomla-framework/string#22.
Since this is the wrong way to fix this, I'm closing this one.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-16 21:01:44 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
?
?
|
||
When this helps we should also patch this upstream in the string package: https://github.com/joomla-framework/string/blob/master/src/phputf8/utf8.php#L45 it seams some other changes have been done there in the meantime too.