? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
16 Jun 2019

Pull Request for Issue #25229 .

Summary of Changes

Update the database package from framework so it contains the database function "WhereNotIn" needed by 4.0-dev since PR #25055 has been merged and needed also for PR #25090 .

Testing Instructions

An easier and faster test you can find below in section "Alternative Testing Instructions".

  1. Install clean 4.0-dev, i.e. checkout latest 4.0-dev, run composer install and npm install.
  2. In backend, install some extension which has an update site, e.g. one of the supported languages for 4.0, e.g. German DE.
  3. Try to uninstall the extension. Result: See section "Actual result" below.
  4. Log out from backend.
  5. Apply this PR by manually applying the changes in the composer.lock file.
  6. Run composer install.
  7. Log in again at backend and try to uninstall the extension (or remaining parts, or install again another language and try to uninstall that if there is no remaining part to be uninstalled). Result: See section "Expected result" below.

Expected result

Extension is uninstalled.

Actual result

screen shot 2019-06-16 at 10 43 42

Alternative Testing Instructions

  1. Install clean 4.0-dev, i.e. checkout latest 4.0-dev, run composer install and npm install.
  2. Check which files contain string "wherenotin" (case-insentitive).
    E.g. on Linux:
richard@vmkubu01:~/lamp/public_html/joomla-cms-4.0-dev$ find ./ -type f -name "*\.php" -exec grep -il "wherenotin" {} \;
./plugins/extension/joomla/joomla.php
richard@vmkubu01:~/lamp/public_html/joomla-cms-4.0-dev$

On Windows command line, use findstr /s /m /i /c:"wherenotin" *.php

  1. Apply this PR by manually applying the changes in the composer.lock file.
  2. Run composer install.
  3. Check again which files contain string "wherenotin" (case-insentitive).
    E.g. on Linux:
richard@vmkubu01:~/lamp/public_html/joomla-cms-4.0-dev$ find ./ -type f -name "*\.php" -exec grep -il "wherenotin" {} \;
./libraries/vendor/joomla/database/src/QueryInterface.php
./libraries/vendor/joomla/database/src/DatabaseQuery.php
./plugins/extension/joomla/joomla.php
richard@vmkubu01:~/lamp/public_html/joomla-cms-4.0-dev$

On Windows command line, use findstr /s /m /i /c:"wherenotin" *.php

avatar richard67 richard67 - open - 16 Jun 2019
avatar richard67 richard67 - change - 16 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2019
Category External Library Composer Change
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jun 2019
Title
[4.0] Update joomla/database package from framework to solve issue #25229
[4.0] Update joomla/database package from framework
avatar franz-wohlkoenig franz-wohlkoenig - edited - 16 Jun 2019
avatar richard67 richard67 - change - 16 Jun 2019
The description was changed
avatar richard67 richard67 - edited - 16 Jun 2019
avatar richard67 richard67 - change - 16 Jun 2019
The description was changed
avatar richard67 richard67 - edited - 16 Jun 2019
avatar richard67 richard67 - change - 16 Jun 2019
The description was changed
avatar richard67 richard67 - edited - 16 Jun 2019
avatar richard67
richard67 - comment - 16 Jun 2019

Ping @wilsonge .

avatar wilsonge wilsonge - change - 16 Jun 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-16 12:41:46
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 16 Jun 2019
avatar wilsonge wilsonge - merge - 16 Jun 2019
avatar wilsonge
wilsonge - comment - 16 Jun 2019

Thanks!

avatar richard67
richard67 - comment - 16 Jun 2019

Welcome ?

Add a Comment

Login with GitHub to post a comment