User tests: Successful: Unsuccessful:
This PR started off just removing the title "author" which is meaningless and not needed.
I then fixed some codestyle issues (spaces to tabs)
I then simplified the if/else statements
Other than the now missing word Author being displayed on hovering the author name there should be no visible differences
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Administration com_content |
good idea
I have tested this item
@brianteeman The "Author" title indeed was useless. But in the same views, the links to the categories have title "Edit category". So maybe the title of the link to the author should have been changed to "Edit user" instead just removing it? Now it is a bit inconsistent, one kind of links (category) has title, other (author) has not. Do you plan to work on that with a future PR, e.g. remove the other title, too, and maybe addd tool tips to all those links? In this case, if it will be changed anyway, I would give this PR here a good test despite of the new inconsistence. Code analysis looks good, real test shows no changes except of the removed title.
I have tested this item
Despite of the inconsistency that one kind of links (category) has a title and the other one (author) has not after this PR, this PR does what it shall do.
I guess other link titles will be handled with other PRs.
Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
Labels |
Added:
?
|
I do think that @richard67 has a point here. All the other titles say Edit ...
, so why just not change the title to Edit Author
? Unless the idea is to remove all the other labels as well.
The logic behind my thinking on this is as follows.
This is a list of articles and if you were looking to change the author of an article on an article then you would rightly assume that a link called "edit author" would let you do that. But that's not what the link does. The links lets you see the details of the author and change those details. It does not let you change the author of the article.
I assume that this logic is why it originally just said "Author"
I removed the title of author as it is "useless" extra information as we know it is an author because it is a column called author
Hmm, yes, Brian is right, it would be misleading.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-23 16:31:26 |
Closed_By | ⇒ | wilsonge |
Thanks!
Thanks
To simplify it further: