? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Jun 2019

This PR started off just removing the title "author" which is meaningless and not needed.

I then fixed some codestyle issues (spaces to tabs)

I then simplified the if/else statements

Other than the now missing word Author being displayed on hovering the author name there should be no visible differences

avatar brianteeman brianteeman - open - 15 Jun 2019
avatar brianteeman brianteeman - change - 15 Jun 2019
Status New Pending
avatar brianteeman brianteeman - change - 15 Jun 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2019
Category Administration com_content
avatar Quy
Quy - comment - 15 Jun 2019

To simplify it further:

<?php if ((int) $item->created_by != 0) : ?>
        <a href="<?php echo Route::_('index.php?option=com_users&task=user.edit&id=' . (int) $item->created_by); ?>">
                <?php echo $this->escape($item->author_name); ?>
        </a>
<?php else : ?>
        <?php echo Text::_('JNONE'); ?>
<?php endif; ?>
<?php if ($item->created_by_alias) : ?>
        <div class="smallsub"><?php echo Text::sprintf('JGLOBAL_LIST_ALIAS', $this->escape($item->created_by_alias)); ?></div>
<?php endif; ?>
``
avatar brianteeman
brianteeman - comment - 15 Jun 2019

good idea

avatar Quy
Quy - comment - 15 Jun 2019

I have tested this item successfully on b95d4f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25214.

avatar Quy Quy - test_item - 15 Jun 2019 - Tested successfully
avatar richard67
richard67 - comment - 16 Jun 2019

@brianteeman The "Author" title indeed was useless. But in the same views, the links to the categories have title "Edit category". So maybe the title of the link to the author should have been changed to "Edit user" instead just removing it? Now it is a bit inconsistent, one kind of links (category) has title, other (author) has not. Do you plan to work on that with a future PR, e.g. remove the other title, too, and maybe addd tool tips to all those links? In this case, if it will be changed anyway, I would give this PR here a good test despite of the new inconsistence. Code analysis looks good, real test shows no changes except of the removed title.

avatar richard67
richard67 - comment - 16 Jun 2019

I have tested this item successfully on b95d4f5

Despite of the inconsistency that one kind of links (category) has a title and the other one (author) has not after this PR, this PR does what it shall do.
I guess other link titles will be handled with other PRs.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25214.

avatar richard67 richard67 - test_item - 16 Jun 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jun 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2019

Status "Ready To Commit".

avatar brianteeman brianteeman - change - 18 Jun 2019
Labels Added: ?
avatar roland-d
roland-d - comment - 23 Jun 2019

I do think that @richard67 has a point here. All the other titles say Edit ... , so why just not change the title to Edit Author? Unless the idea is to remove all the other labels as well.

avatar brianteeman
brianteeman - comment - 23 Jun 2019

The logic behind my thinking on this is as follows.
This is a list of articles and if you were looking to change the author of an article on an article then you would rightly assume that a link called "edit author" would let you do that. But that's not what the link does. The links lets you see the details of the author and change those details. It does not let you change the author of the article.
I assume that this logic is why it originally just said "Author"
I removed the title of author as it is "useless" extra information as we know it is an author because it is a column called author

avatar richard67
richard67 - comment - 23 Jun 2019

Hmm, yes, Brian is right, it would be misleading.

avatar wilsonge wilsonge - change - 23 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-23 16:31:26
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Jun 2019
avatar wilsonge wilsonge - merge - 23 Jun 2019
avatar wilsonge
wilsonge - comment - 23 Jun 2019

Thanks!

avatar brianteeman
brianteeman - comment - 23 Jun 2019

Thanks

Add a Comment

Login with GitHub to post a comment