[#25213] - Fix for menu items containing nested field groups and no immediate fields in request
- Fixed in Code Base
- 25 Jun 2019
- Medium
- Build: staging
- # 25213
- Diff
- SharkyKZ:j3/menuItemRequest
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25211.
Summary of Changes
Get request group fields recursively.
Testing Instructions
Create/modify view layout XML file to contain a nested field group but no immediate fields in request field group, e.g.:
<fields name="request">
<fieldset name="request">
<fields name="filter">
<field
name="id"
type="category"
label="JGLOBAL_FIELD_CATEGORIES_CHOOSE_CATEGORY_LABEL"
description="JGLOBAL_FIELD_CATEGORIES_CHOOSE_CATEGORY_DESC"
extension="com_content"
show_root="true"
required="true"
/>
</fields>
</fieldset>
</fields>
Create a menu item for the view.
Inspect Link field value.
Expected result
Nested group field parameters included, e.g.:
index.php?option=com_content&view=categories&filter[id]=0
Actual result
Nested group field parameters not included, e.g.:
index.php?option=com_content&view=categories
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
@muesliflyer please mark your test as successfully (how to: https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results)
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25213.
For the test, I installed Patch Tester 2.0.1 (the stable version). When fetching the patch data, I got an error:
Notice: Undefined offset: 0 in /var/www/bugtesting/libraries/joomla/database/query.php on line 351 {"success":false,"message":"Error inserting pull request data into the database: Column count doesn't match value count at row 1","messages":null,"data":null}
Then I installed the latest version 3.0.0 beta 4. Then it worked.
Then I installed the latest version 3.0.0 beta 4. Then it worked.
??
@infograf768 it's about Patchtester.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25213.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-25 12:38:50 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
This works for me. Thanks for the quick fix.