? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Jun 2019

This PR removes the class from everywhere that it has no effect being applied to a title. This will make it easier to find the cases where hasTooltip is being used with HTMLHelper::_('tooltipText' and to decide on the most appropriate accessible solution.

Code review should be enough

avatar brianteeman brianteeman - open - 15 Jun 2019
avatar brianteeman brianteeman - change - 15 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2019
Category Administration com_banners com_categories com_contact com_content com_contenthistory com_joomlaupdate com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_templates com_users Front End Layout Modules
avatar Quy
Quy - comment - 15 Jun 2019

I have tested this item successfully on e1f500e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25215.

avatar Quy Quy - test_item - 15 Jun 2019 - Tested successfully
avatar brianteeman brianteeman - change - 16 Jun 2019
Labels Added: ?
avatar Quy
Quy - comment - 16 Jun 2019

I have tested this item successfully on 8de7a5e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25215.

avatar Quy Quy - test_item - 16 Jun 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Jun 2019

Conflicts resolved

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Jul 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Jul 2019

Status "Ready To Commit".

avatar infograf768 infograf768 - change - 1 Jul 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 16 Jul 2019

@wilsonge it would be great if this could be merged

avatar wilsonge wilsonge - change - 16 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-16 19:31:34
Closed_By wilsonge
avatar wilsonge wilsonge - close - 16 Jul 2019
avatar wilsonge wilsonge - merge - 16 Jul 2019
avatar wilsonge
wilsonge - comment - 16 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 16 Jul 2019

Thanks - I can continue the cleanup now

Add a Comment

Login with GitHub to post a comment