[#25198] - Fix update extracted files counter
- Fixed in Code Base
- 2 Jul 2019
- Medium
- Build: staging
- # 25198
- Diff
- Quy:patch-3
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #21922 .
Summary of Changes
During update, 4 counters are visible (percent complete, bytes read, bytes extracted and files extracted). Expected is that the values of all counters increase during the update.
This PR uses the cumulative total and not the extracted files count.
Testing Instructions
Install the previous version of Joomla.
Install patch.
Then update to the current version.
or code review
Actual result
The value of files extracted increases and decreases.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
Tested update from 3.9.4
My issue with this was that the counters keep on increasing long after the progress bar has reached 100%
This PR does not solve that.
@frostmakk please mark your test as unsuccessfully (how to: https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results)
Not sure it would be correct to mark as unsuccessful, as long as the PR probably didn't address my view of the issue anyway.
@frostmakk if you have a different issue which isn't solved by this Pull Request and not reported yet please open a new Issue.
@frostmakk I will look into it and fix it here.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25198.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25198.
| Status | Pending | ⇒ | Ready to Commit |
since 1st test only branch merge so 2 tests
setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25198.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-02 07:07:24 |
| Closed_By | ⇒ | HLeithner |
thx
@manfredvdn @frostmakk please test > https://docs.joomla.org/Testing_Joomla!_patches