I have tested this item ✅ successfully on c0c48f5

I have tested this item ✅ successfully on c0c48f5

This is very inefficient as we're running a DB query for every item.

Tried my best. I guess I will just give up. No idea how to make it more efficient.
As for “prepared statement” use, would it make the query more efficient ?

If we're fine with removing custom strings/states here, select component status (e.enabled) in the model query and use that.

Otherwise, the complete solution is probably to copy-paste in JHtmlJgrid::published() into Joomla\Component\Menus\Administrator\Service\HTML\Menus::published() and adapt it to custom states.

As for “prepared statement” use, would it make the query more efficient ?

unfortunately not, it help to prevent SQL Injection

@SharkyKZ
Corrected by using existing model query. Adding the publish_down and publish_up to the custom strings/state would just make such a tip too complicated.

@alikon
As I deleted the new method, no use anymore for a prepare statement.

@810
Sorry, please test again.

I have tested this item ✅ successfully on 409e60f

The following were removed but not in the language file.

COM_MENUS_EXTENSION_UNPUBLISHED_ENABLED
COM_MENUS_EXTENSION_PUBLISHED_DISABLED
COM_MENUS_EXTENSION_UNPUBLISHED_DISABLED

Please advise if issue #19874 is related.

Please advise if issue #19874 is related.

I do not think so. Here is the process:

In 3.x we use the override menus.state (and publish_down as well as publish_up do not exist).

In case the component exists, is disabled and the item is Published we have a warning icon.

In case the component exists, is disabled and the item is Unpublished we have a trash icon.

In 4.0, with this PR, we get an Unpublished icon in both cases WITH the new badge when the component is disabled and specific icons for published/unpublished or publish_up and publish_down when enabled.

Filtering by Published/Unpublished will work fine whatever the status of the component.

The case of the unexisting component ( #19874 ), this both for 3.x and 4.0, is not dealt with the same way: it is done in the View itself. It defaults to using the Unpublished icon and adds the following text below the Menu Item title as it just sets the value to $item->item_type:

else
					{
						if (preg_match("/^index.php\?option=([a-zA-Z\-0-9_]*)/", $item->link, $result))
						{
							$value = JText::sprintf('COM_MENUS_TYPE_UNEXISTING', $result[1]);
						}
						else
						{
							$value = JText::_('COM_MENUS_TYPE_UNKNOWN');
						}
					}
					break;

This PR adds a badge "Component not found." in this case for 4.0.

Basically JHtmlJGrid does not deal either with enabled or unexisting.

Should the badge display at the same location as Hidden?

@Quy

Should the badge display at the same location as Hidden?

I have replied on this here:
#25197 (comment)

I have tested this item ✅ successfully on 29318a1

RTC as last changes since @810 tested concerned only deleting some unsused lang strings.

RTC as last changes since @810 tested concerned only deleting some unsused lang strings.

@wilsonge
Merge?

Thank you.