Feeling Lucky
NPM Resource Changed
?
[#25196] - [4.0] Javascript tweaks
- Closed
- 16 Jun 2019
- Medium
- Build: 4.0-dev
- # 25196
- Diff
- C-Lodder:js-tweaks
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Remove some unecessary code for IE
- Remove
html5.jsandhtml5fallback.js - Remove
"use strict";calls in ES6 files as they're not required - Update
draggable.jsto ES6
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
dgrammatiko
- comment
- 13 Jun 2019
ES6 or greater is not forcing strict mode unless you’re in module mode, eg the de facto for current code. Also if you wanna go this way you should drop all the iife as these were an ES5 technic.
I think there is a greater question/problem that needs to be answered before any of these enhancements get merged and that is: “is joomla willing to really follow the new JavaScript paradigm?”
Fedik
- comment
- 16 Jun 2019
I am agree with @dgrammatiko . "use strict"; must stay.
It does not enabled magically if you start to use () => {} instead of function(){}. It a question about a scope isolation.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-16 08:57:44 |
| Closed_By | ⇒ | C-Lodder | |
| Labels |
Added:
NPM Resource Changed
?
|
||
C-Lodder
- comment
- 16 Jun 2019
Thanks for doing this