[#25078] - [4.0] Handle errors generated by language downloads gracefully
- Fixed in Code Base
- 8 Jun 2019
- Medium
- Build: 4.0-dev
- # 25078
- Diff
- roland-d:feature/handle-installation-errors-gracefully
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
While trying to install a multi-language site I ran into several errors but was not given any information about them on screen. I found them in the XHR request and later in the log file.
Testing Instructions
- Get a clean Joomla 4 checkout
- Start the installation process
- When the installer is done with the basics, you see this screen:
- Click on Customize Installation
- Select the
Dutchlanguage - Scroll down and click Next
- You are back at step 3. If you are lucky you would see a message flash by
- Apply the patch
- Select the
Dutchlanguage - Scroll down and click Next
- Now you stay on the page and see this warning message:
I have another problem with the French language, here you see no warning but an error.
- Select the
Frenchlanguage - Scroll down and click Next
- Now you stay on the page and see this error message:
Expected result
User is shown the error message
Actual result
Message is shown but page is immediately redirected so impossible to read.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Installation |
@brianteeman I can take a look later to see which others there are. Feel free to post your comments later on as I am not sure when I will be back.
I have tested this item
Tested a bit different to the description:
- Installed J4 with currend 4.0-dev.
- Customize installation: Tried Dutch language => Failed, but no warning or error message shown.
- Customize installation: Tried French language => Failed, but no warning or error message shown.
- Logged in at backend.
- Installed Patchtester (I have modified up-to-date package which works).
- Installed patch of this PR with Patchtester.
npm i(Not necessary I guess, but who knows).- Cleared database and removed configuration.php
- Repeated steps 1 to 3: This time the warning and error messages were shown.
In case of French language, I would like to see in addition to the error message the warning like shown for the Dutch language. But this might be done in another PR. This one here works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25078.
Reminder. Afaik language installation atm is limited to french,german and persian.
it has always been broken at J4 installation time, but works fine from admin installer install languages.
@infograf768 Sure, we know that. This PR uses that fact to have some error happening, and fixes the fact that the warnings or error messages never became visible.
I have tested this item
Does what it says
Can you open an issue for the JNamespacePsr4Map not found
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25078.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Labels |
Added:
?
|
||
@brianteeman I posted PR #25121 to fix the JNamespacePsr4Map error.
Thanks
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-08 19:13:14 |
| Closed_By | ⇒ | SniperSister |
Merged, thanks!
Hi @roland-d thanks for this
The problem of the messages disappearing is not limited to the ones you identified but i am not at my pc this morning to look and my memory is failing