[#25077] - [4.0] Removing base tag from frontend
- Fixed in Code Base
- 15 Jun 2019
- Medium
- Build: 4.0-dev
- # 25077
- Diff
- Hackwar:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue #9010.
Summary of Changes
This removes the base tag from the frontend. The idea of the base tag is to define a base for relative URLs. Consider you have the site http://www.example.com/this/is/index.php/with/more/content and all requests should go to the folder http://www.example.com/this/is/, you would set the base tag to exactly that URL. However, we are setting that base tag always to the current URL, which simply is wrong. Even worse, we aren't doing it correctly, because we are forgetting the query part. So we are not setting it to a special path, but are just using the current URL. Now guess what the default value is, when that base tag is NOT set at all. The answer is not "42", but: The current URL.
A quick check shows that neither Wordpress nor Drupal or Typo3 seem to have a base tag in their default output. We are just oh-so-special... Sorry...
Testing Instructions
Apply this change and then check if everything on your site still works as expected.
This would be a fix for an issue that is over 3 years old and that has been discussed several times in the Joomla project... Would be nice to finally solve that.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Does this need to be removed as well?
joomla-cms/libraries/src/Document/Renderer/Html/MetasRenderer.php
Lines 71 to 77 in 6caacee
@brianteeman I thought about this. I opted for keeping that feature generally available to whoever wants to use it, but just to not use it in the SiteApplication. That makes the (small) B/C break smaller.
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25077.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25077.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25077.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-15 20:47:28 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
|
||
Thank you
This needs to be documented in the migration guide.
@HLeithner please add the documentation required label
thx franz
@Spudley @izharaazmi please test > https://docs.joomla.org/Testing_Joomla!_patches