NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 May 2019

#24775 has modified the label id for modal select fields, therefore breaking the display of these fields in the associations tab when editing an item

Summary of Changes

Replacing _id by _name in the associations-edit js file

Testing Instructions

Multilingual site.
Install at least 2 languages (from fr-FR, de-DE, fa-IR)
Use the Multilingual Sample Data module to set a basic multilingual site.
Edit an article, for example Article (en-GB) and display the Associations tab

Before patch

The language select field used by the article edited English (en-GB) displays although it should not.

Screen Shot 2019-05-30 at 08 43 49

After patch

Issue solved.

Screen Shot 2019-05-30 at 08 40 03

Documentation Changes Required

avatar infograf768 infograf768 - open - 30 May 2019
avatar infograf768 infograf768 - change - 30 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2019
Category JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 30 May 2019

I have tested this item successfully on 23ddfc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25060.

avatar richard67
richard67 - comment - 30 May 2019

I have tested this item successfully on 23ddfc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25060.

avatar richard67 richard67 - test_item - 30 May 2019 - Tested successfully
avatar lavipr
lavipr - comment - 30 May 2019

I have tested this item successfully on 23ddfc4

Steps: Test instructions followed.
The patch works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25060.

avatar lavipr
lavipr - comment - 30 May 2019

I have tested this item successfully on 23ddfc4

Steps: Test instructions followed.
The patch works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25060.

avatar lavipr lavipr - test_item - 30 May 2019 - Tested successfully
avatar alikon alikon - change - 30 May 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 30 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25060.

avatar alikon
alikon - comment - 30 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25060.

avatar alikon
alikon - comment - 30 May 2019

@bot why setting RTC remove labels: NPM Resource Changed and PR-4.0-dev

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 May 2019

@bot why setting RTC remove labels: NPM Resource Changed and PR-4.0-dev

this happens every time.

avatar infograf768 infograf768 - change - 30 May 2019
Labels Added: NPM Resource Changed ? ?
avatar wilsonge wilsonge - change - 30 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-30 15:55:55
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 May 2019
avatar wilsonge wilsonge - merge - 30 May 2019
avatar wilsonge
wilsonge - comment - 30 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment