[#25059] - [4.0] Remove element selector that does not exist
- Fixed in Code Base
- 30 May 2019
- Medium
- Build: 4.0-dev
- # 25059
- Diff
- roland-d:feature/tags-batch-modal-cancel
- Pending Hound Hound is busy sniffing around... Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Closing the batch modal in Tags causes a JavaScript error due to trying to access a non-existing element. Looks like a case of copy/paste because there is of course no Tag selector in the batch modal on the Tags page.
Testing Instructions
- Open the developer Console with F12
- Open the console tab in the developer console
- Go to Components -> Tags
- Check 1 or more tags (if you have none, create one)
- Click on the Batch button
- Click on the Cancel button
- Notice in the console a JavaScript error
- Apply patch
- Reload page
- Click on the Batch button
- Click on the Cancel button
- Notice in the console there is no JavaScript error
Expected result
No JavaScript error
Actual result
A JavaScript error
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Administration |
@brianteeman Correct, same issue exists there. The JS is trying to target the Tags option in the modal but it doesn't exist in the Tags view for obvious reasons. You can see it in the modal at Contacts for example:
That is the element it tries to access.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25059.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25059.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25059.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-30 15:36:54 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
not saying this is wrong as i havent tested it but it is the same in j3