? Success

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
29 May 2019

Summary of Changes

Updated SQL queries to prepared statements and made some cleanups around the queries.

Testing Instructions

Test instruction could be found in the original PR:
#21851

Video: https://www.youtube.com/watch?v=l0_jFjswObI
For this, you need an extension which has an update with new changes in extension files.
So,
You can use these components
com_helloworld.0.0.1 https://www.dropbox.com/s/106cgn1lclp9dxm/com_helloworld.0.0.1.zip?dl=0
com_helloworld.0.0.2 https://www.dropbox.com/s/xhl8p0nz3wdvapj/com_helloworld.0.0.2.zip?dl=0
Download this branch/PR then install fresh Joomla using this branch/PR.
Go to the template manager.
Create an override of that extension before the update.
See the diff view of that file by using a toggle button in the top right corner. ** Expected:** No difference.
Now update your extension. ** Expected:** If your created override file got any update in core you can see notification message number of files updated.
Go to template manager check new tab you can see which files are updated.
Click on the name of the file you will get redirect to edit view of that file.
Now you can see the changes in diff view.
Adjust your override file if you want and then you can delete that file list history or mark as checked.

Expected result

Nothing changed.

abe8d65 29 May 2019 avatar HLeithner cs
avatar HLeithner HLeithner - open - 29 May 2019
avatar HLeithner HLeithner - change - 29 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2019
Category Front End Plugins
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 May 2019
Title
Add prepared statements for plg_installer_override
[4.0] Add prepared statements for plg_installer_override
avatar franz-wohlkoenig franz-wohlkoenig - edited - 30 May 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 May 2019
Title
Add prepared statements for plg_installer_override
[4.0] Add prepared statements for plg_installer_override
avatar HLeithner HLeithner - change - 30 May 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 11 Jun 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-11 09:49:17
Closed_By wilsonge
avatar wilsonge wilsonge - close - 11 Jun 2019
avatar wilsonge wilsonge - merge - 11 Jun 2019
avatar wilsonge
wilsonge - comment - 11 Jun 2019

Thanks!

Add a Comment

Login with GitHub to post a comment