? ? Success

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
28 May 2019

Pull Request for Issue #22216.

Summary of Changes

Adds prefix to categories created on the fly to allow creating categories starting with numbers.

Testing Instructions

  1. Create a category and remember the ID (or use an existing category) e.g. "2"
  2. Create a new article or edit one and try to create a new category with the name: "2nd workshop" (important: the ID of the category from 1. has to be the leading character) by typing in the name in the category select on the right side + confirm with [ENTER]
  3. Save article

Expected result

A new category is created and assigned to the article

Actual result

The old category from 1 is assigned

Documentation Changes Required

New Categoryedit field property added.
Categories created on the fly contain #new# prefix.

avatar SharkyKZ SharkyKZ - open - 28 May 2019
avatar SharkyKZ SharkyKZ - change - 28 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2019
Category Administration com_categories com_content Language & Strings JavaScript
663b8c0 28 May 2019 avatar SharkyKZ Typo
avatar SharkyKZ SharkyKZ - change - 28 May 2019
Labels Added: ? ?
avatar SharkyKZ
SharkyKZ - comment - 28 May 2019

On second thought this could be a B/C break for those programatically adding articles using the model. If using category title, it must now contain #new# prefix or else saving fails. Thoughts?

avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2019
Category Administration com_categories com_content Language & Strings JavaScript Administration com_categories com_content JavaScript
avatar SharkyKZ
SharkyKZ - comment - 28 May 2019

Should be OK now.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2019
Category Administration com_categories com_content JavaScript Administration com_banners com_categories com_contact com_content com_newsfeeds JavaScript
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Jun 2019
Title
Creating categories on the fly with numbers.
Creating categories on the fly with numbers
avatar franz-wohlkoenig franz-wohlkoenig - edited - 15 Jun 2019
avatar ReLater
ReLater - comment - 15 Jun 2019

I have tested this item successfully on 4cf418c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25024.

avatar ReLater ReLater - test_item - 15 Jun 2019 - Tested successfully
avatar SharkyKZ SharkyKZ - change - 15 Jun 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 15 Jun 2019
avatar Quy
Quy - comment - 15 Jun 2019

I have tested this item successfully on 4cf418c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25024.

avatar Quy Quy - test_item - 15 Jun 2019 - Tested successfully
avatar Quy Quy - change - 15 Jun 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 15 Jun 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25024.

avatar HLeithner
HLeithner - comment - 20 Jul 2019

@bembelimen can you confirm that this fix your problem?

avatar HLeithner HLeithner - change - 22 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-22 20:54:02
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 22 Jul 2019
avatar HLeithner HLeithner - merge - 22 Jul 2019
avatar HLeithner
HLeithner - comment - 22 Jul 2019

thx

avatar wilsonge
wilsonge - comment - 22 Jul 2019

Sorry I just came across this. Isn't this a b/c break for people using com_categories because they need to change their models (like we had to in com_content). I think the component specific ones in banners and contact is fine) but not the com_categories one which is generic

avatar SharkyKZ
SharkyKZ - comment - 22 Jul 2019

@wilsonge No, the custom prefix property added to JFormFieldCategoryEdit is optional.

avatar wilsonge
wilsonge - comment - 23 Jul 2019

OK makes sense - missed that - thanks!

Add a Comment

Login with GitHub to post a comment