? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
27 May 2019

It really is not a warning to display "No matching results" that should have a class of alert-info.

There are also a few language strings that have been replaced with the generic "No matching results"

Before

image

After

image

e006cbf 27 May 2019 avatar brianteeman lang
avatar brianteeman brianteeman - open - 27 May 2019
avatar brianteeman brianteeman - change - 27 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 May 2019
Category Administration com_associations com_banners com_categories com_contact com_content com_csp com_fields com_finder com_installer com_languages com_menus
bd6ada0 27 May 2019 avatar brianteeman oops
avatar brianteeman brianteeman - change - 27 May 2019
Labels Added: ?
avatar alikon
alikon - comment - 27 May 2019

make sense

avatar alikon
alikon - comment - 27 May 2019

I have tested this item successfully on bd6ada0

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25023.

avatar alikon alikon - test_item - 27 May 2019 - Tested successfully
avatar Quy
Quy - comment - 27 May 2019

I have tested this item successfully on bd6ada0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25023.

avatar Quy Quy - test_item - 27 May 2019 - Tested successfully
avatar Quy Quy - change - 27 May 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 27 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25023.

avatar wilsonge wilsonge - change - 27 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-27 22:27:58
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 27 May 2019
avatar wilsonge wilsonge - merge - 27 May 2019
avatar wilsonge
wilsonge - comment - 27 May 2019

Thanks!

avatar brianteeman
brianteeman - comment - 27 May 2019

Thanks

Add a Comment

Login with GitHub to post a comment