Thanks very much for this PR

@alikon Do you plan to add the SQL for inserting the new system plugin into the #__extensions table to joomla.sql scripts and add schema updates for the same thing?

yes, if i only got some feedback before....it seems lack of interest as for now

Hey. This is a great PR and something people at managed and shared hosting provider need.
Trust me I know working for year at web hosting company. Most of them just give them an interface to create something like pseudo cronjobs. And on the other hand most users are not familiar with managing a server and cronjobs. So this would be a nice addon to help them.

And I really want to test this, but at the moment it's not possible because the Commands compatible with the Joomla\Console\Command\AbstractCommand::configure().

I guess at least the return type declaration is missing.

This should be look like this:

	protected function configure(): void

@f-hamel should be ready for test
@richard67 sql added

At the Moment. The CLI seems to be broken by this PR.

php joomla.php list
cli 4.0.0-alpha11-dev

Usage:
  command [options] [arguments]

Options:
  -h, --help            Display the help information
  -q, --quiet           Flag indicating that all output should be silenced
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Flag to disable interacting with the user
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

The command list is missing.

Also

php joomla.php job:run

returns nothing at the moment on console. So there is no output.
I don't know if there is maybe any php or mysql error. Because my error reporting is broken at the moment. Maybe some else who test this will have more information or will test this successful.

ok, you are right the CLI part needs some more refactoring. meanwhile, can we test the no-CLI side ?

@f-hamel previous reported issues fixed, can you retest ?

I have tested this item ✅ successfully on 4d0589f

It is a very great and usefull PR. It worked for me, but I noticed two things, what I want to ask here.

I installed the schedule and the two job plugins. Where plugin one runs every 10 minute and the second one every second minute. When I change some settings in the scheduler, the job queue is kind of resetted, so that both jobs starts again, even if there was some minute to the 10 minute waiting time of job one. But I think this is known and ok.

Then I tested the web cron trigger url. It worked as expected, so that the onExecuteScheduledTask is triggered the same as the web page reload. But maybe something is wrong, because if I open / curl this link index.php?webcronkey=mywebcronactivationkey just the home page is loaded, it doesnt matter if the key is right or not, of course it is working, but I am not sure if this is expected.

I hope @alikon understand my explaination ?

thanks for testing

when the webcron option is setted if the activation key is wrong the scheduled job's are not executed, even if the page is rendered

when you change scheduler or job settings this could affect the next job execution time
there is an hidden param that holds the last run time so the next run is expected based to that last rum time + the new setting

I have tested this item ✅ successfully on 4d0589f

I have tested this and its working perfectly, it only created the log file to mysite/logs/joomla_web.php

I have tested this item ✅ successfully on 4d0589f

I have tested this and its working perfectly, it only created the log file to mysite/logs/joomla_web.php

Hi, I've tested "php joomla.php job:run" without success.
I get this console error:

ladyj@jarvis:~/Area51/Projects/Web/area51.ladyj.eu/joomla-cms-4/cli$ php joomla.php job:run
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Symfony\Component\Debug\ExceptionHandler::handle() must be an instance of  Exception, instance of ParseError given in /home/ladyj/Area51/Projects/Web/area51.ladyj.eu/joomla-cms-4/libraries/vendor/symfony/debug/ExceptionHandler.php:118
Stack trace:
#0 [internal function]: Symfony\Component\Debug\ExceptionHandler->handle(Object(ParseError))
#1 {main}
thrown in /home/ladyj/Area51/Projects/Web/area51.ladyj.eu/joomla-cms-4/libraries/vendor/symfony/debug/ExceptionHandler.php on line 118

I get the same error with: "php joomla.php database:export".

ladyj@jarvis:~/Area51/Projects/Web/area51.ladyj.eu/joomla-cms-4/cli$ php joomla.php database:export
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Symfony\Component\Debug\ExceptionHandler::handle() must be an instance of Exception, instance of ParseError given in /home/ladyj/Area51/Projects/Web/area51.ladyj.eu/joomla-cms-4/libraries/vendor/symfony/debug/ExceptionHandler.php:118
Stack trace:
#0 [internal function]: Symfony\Component\Debug\ExceptionHandler->handle(Object(ParseError))
#1 {main}
thrown in /home/ladyj/Area51/Projects/Web/area51.ladyj.eu/joomla-cms-4/libraries/vendor/symfony/debug/ExceptionHandler.php on line 118

@mbabker could it be due to something wrong on my environment?

I have tested this item ✅ successfully on 4d0589f

the two provdided test jobs are running. Missing language strings in job2 plugin for minutes and hours

@ladyjer there was a silly error in the opening of the comment #25022 (review) fixed by 099c26b
so nothing wrong with your environment
the CLI side is ready to be tested....

@alikon I've just created updated versions of your 2 test plugins so they use language file names without the "en-GB." at the beginning, like we do it in core now. You can find them here:

• https://test5.richard-fath.de/plg_job_one.zip
• https://test5.richard-fath.de/plg_job_two.zip

Please download and check and if ok, either replace your downloads by these or change the links in your testing instructions so they point to my links.

@alikon Beside the language ("runned") and variable name I've mentioned in my previous review I've found following when testing CLI:

I.e. "job:list" works well, "job:run" works too but shows the PHP notice (same notice 2 times) about Undefined index: REMOTE_ADDR in /libraries/vendor/joomla/utilities/src/IpHelper.php on line 488. Am trying to find reason, but maybe @SharkyKZ has an idea?

Update: Could that be related to webserver settings? It seems not to be related to this PR, I think. But at the other hand it makes the log fail, i.e. when running with CLI there is nothing in the logfile joomla_web.php for these runs.

@alikon Another thing I just see is that the scheduler plugin still uses old style language file names starting with "en-GB.". Should I make a PR for your branch so you can apply all my suggested changes from review plus the language file name change with one click?

@alikon Made alikon#64 to save you some work. Contains all changes in my above reviews, too.

The PHP notice on CLI mentioned in one of my comments above seems really to be an error in the IpHelper. It doesn't check if the array key 'REMOTE_ADDR' exists before checking it in line 488. So this seems not to be a mistake in this PR here.

IMO, changes do not belong in Joomla\CMS\Plugin\PluginHelper.

@SharkyKZ Which ones you mean? The "1918" to "1970" date correction I've suggested above? If you mean that, let me know where else to change them. Or do you mean the PHP notice in CLI? This should already be solved in the utilities package with your PR joomla-framework/utilities#23, I have to check if it has been merged into the 2.0-dev branch there. If so, we maybe just have to update the utilities package in the cms.

Update: The "1918" date correction I've suggested above changes something which will be added to the plugin helper class by this PR here. So if it is wrong to add something there then this PR does it wrong (what I don't believe right now).

Update 2: I just saw the changes in joomla-framework/utilities#23 haven't been merged up yet to the 2.0-dev branch of the utilities package.

I mean any code added to PluginHelper class. At least currently the code is called only by Scheduler plugin so it's more suitable for the code to be contained in the plugin. But I'm not sure what the intention here is.

I'm also not sure how correct is the use of checked_out_time property here.

@SharkyKZ Well I can't say if it's right to add code there or not, but that was then done by this PR and not by my suggested changes. Regarding the "abuse" of the checked out time column: Yes, I agree, it looks a bit like a hack to me. But I could live with that.

Corrected path to logs folder in description.

Corrected path to logs folder.

@alikon So, now I've tested again, and it works for me as described (web, webcron and cli).

What remains to be clarified is the architectural question raised by @SharkyKZ if the PluginHelper class is the right place to add the new stuff, and his and my concern if the usage of the checked_out_time column is suitable for that. For me it works and I'm ok with it, but maybe it can be improved.

I'll wait for some info before I mark my test result with success. Maybe there will be some changes. Just ping me when all is ok or when I shall test again. Now that I know how it works I can do it more quickly.

i'm open to hear all the feedback, and i'm really happy that we have some feedback now

• for the checked_out_time column usage

yes it seems like an hack, but my goal was that, i didn't want to add another column,
i've written this for j3 and then ported on j4 cause it was too late for j3

• for the PluginHelper code

i'm open to listen a better way to do it

@alikon The clean solution would be to create a new class for the new function, if necessary a child class of the plugin helper (@SharkyKZ what do you think?) and to create a new table for the jobs.

@wilsonge Any suggestions?

let's give this a nth attempt

I have tested this:

1. git fetch origin pull/25022/head:patch-81
2. git checkout patch-81
3. New installation because of database changes
4. npm ci is not needed but I did it
5. System panel -> discover -> I found no new system plugin scheduler, but I realize, that it is installed :)

Testing web

1. I set the options

2. I installed the two jobs via System extension Upload package and enabled them.

3. I set the options (In job2 are not language strings but this is not part of this pr)

4. i wait a short time and see this output in the log file.

#
#<?php die('Forbidden.'); ?>
#Date: 2020-02-14 13:45:14 UTC
#Software: Joomla! 4.0.0-beta1-dev Development [ Mañana ] 17-October-2019 20:21 GMT

#Fields: datetime	priority clientip	category	message
2020-02-14T13:45:14+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:45:14+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#1 Total Processing Time: 0.01 seconds.
2020-02-14T13:45:48+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:45:48+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#1 Total Processing Time: 0.01 seconds.
2020-02-14T13:47:43+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:47:43+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#2 Total Processing Time: 0.01 seconds.
2020-02-14T13:48:18+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:18+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#3 Total Processing Time: 0.01 seconds.
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#4 Total Processing Time: 0.02 seconds.
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#5 Total Processing Time: 0.02 seconds.
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#6 Total Processing Time: 0.01 seconds.
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#7 Total Processing Time: 0.03 seconds.
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#8 Total Processing Time: 0.02 seconds.
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#9 Total Processing Time: 0.01 seconds.
2020-02-14T13:48:24+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:24+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#10 Total Processing Time: 0.01 seconds.
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#11 Total Processing Time: 0.01 seconds.
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#12 Total Processing Time: 0.01 seconds.
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#13 Total Processing Time: 0.02 seconds.
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#14 Total Processing Time: 0.02 seconds.
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#15 Total Processing Time: 0.02 seconds.
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#16 Total Processing Time: 0.01 seconds.
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#17 Total Processing Time: 0.02 seconds.
2020-02-14T13:48:34+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:48:34+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#18 Total Processing Time: 0.01 seconds.
2020-02-14T13:49:02+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:49:02+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#19 Total Processing Time: 0.01 seconds.
2020-02-14T13:49:10+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:49:10+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#20 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:05+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:05+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#21 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#22 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#23 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#24 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#25 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#26 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#27 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:08+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:08+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#28 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:09+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:09+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#29 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:22+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:22+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#30 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:27+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:27+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#31 Total Processing Time: 0.01 seconds.
2020-02-14T13:50:38+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:39+00:00	INFO 127.0.0.1	scheduler	Job>jobone Task#1 Processing Time: 1.11 seconds.
2020-02-14T13:50:42+00:00	INFO 127.0.0.1	scheduler	Job>jobtwo Task#1 Processing Time: 3.01 seconds.
2020-02-14T13:50:42+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#32 Total Processing Time: 4.14 seconds.
2020-02-14T13:50:45+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:45+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#33 Total Processing Time: 0.03 seconds.
2020-02-14T13:50:50+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:51+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#34 Total Processing Time: 0.03 seconds.
2020-02-14T13:50:53+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:50:53+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#35 Total Processing Time: 0.02 seconds.
2020-02-14T13:51:36+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:51:36+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#36 Total Processing Time: 0.02 seconds.
2020-02-14T13:51:44+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:51:45+00:00	INFO 127.0.0.1	scheduler	Job>jobone Task#2 Processing Time: 1.01 seconds.
2020-02-14T13:51:45+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#37 Total Processing Time: 1.04 seconds.
2020-02-14T13:51:57+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:51:57+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#38 Total Processing Time: 0.02 seconds.
2020-02-14T13:52:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:52:19+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#39 Total Processing Time: 0.03 seconds.
2020-02-14T13:53:02+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T13:53:03+00:00	INFO 127.0.0.1	scheduler	Job>jobone Task#3 Processing Time: 1.02 seconds.
2020-02-14T13:53:06+00:00	INFO 127.0.0.1	scheduler	Job>jobtwo Task#2 Processing Time: 3.02 seconds.
2020-02-14T13:53:06+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#40 Total Processing Time: 4.05 seconds.

Testing webcron

1. I deledted all log files

2. on scheduler system plugin I set Webcron to yes/enable and set Key to mywebcronactivationkey

3. In my browser i wrote the address: http://localhost/joomla-cms4/index.php?webcronkey=webcronactivationkey
   and I opened it twice.

4. Log file output:

#
#<?php die('Forbidden.'); ?>
#Date: 2020-02-14 14:20:43 UTC
#Software: Joomla! 4.0.0-beta1-dev Development [ Mañana ] 17-October-2019 20:21 GMT

#Fields: datetime	priority clientip	category	message
2020-02-14T14:20:43+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T14:20:44+00:00	INFO 127.0.0.1	scheduler	Job>jobone Task#9 Processing Time: 1.16 seconds.
2020-02-14T14:20:47+00:00	INFO 127.0.0.1	scheduler	Job>jobtwo Task#7 Processing Time: 3.01 seconds.
2020-02-14T14:20:47+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#47 Total Processing Time: 4.46 seconds.
2020-02-14T14:32:28+00:00	INFO 127.0.0.1	scheduler	Scheduler>start
2020-02-14T14:32:29+00:00	INFO 127.0.0.1	scheduler	Job>jobone Task#10 Processing Time: 1.02 seconds.
2020-02-14T14:32:32+00:00	INFO 127.0.0.1	scheduler	Job>jobtwo Task#8 Processing Time: 3.20 seconds.
2020-02-14T14:32:32+00:00	INFO 127.0.0.1	scheduler	Scheduler>stop>task#48 Total Processing Time: 4.23 seconds.

Testing cli/cron

1. I went to the cli folder of my website and run
   php joomla.php job:run
2. I saw a notice, but the jobs are run.
   

The output of the log file:

#
#<?php die('Forbidden.'); ?>
#Date: 2020-02-14 13:58:05 UTC
#Software: Joomla! 4.0.0-beta1-dev Development [ Mañana ] 17-October-2019 20:21 GMT

#Fields: datetime	priority clientip	category	message
2020-02-14T13:58:05+00:00	INFO -	scheduler	Starting Scheduler
2020-02-14T13:58:06+00:00	INFO -	scheduler	Job>jobone Task#4 Processing Time: 1.20 seconds.
2020-02-14T13:58:09+00:00	INFO -	scheduler	Job>jobtwo Task#3 Processing Time: 3.01 seconds.
2020-02-14T13:58:09+00:00	INFO -	scheduler	Scheduler tooks:4.218

I have tested this item ✅ successfully on 4d0589f

thanks for testing
the PHP notice about the REMOTE_ADDR it has been already solved here :
joomla-framework/utilities#23
but that framework version of the utilities package it is still not in J4

@alikon Meanwhile joomla-framework/utilities#23 is available in the 2.0-dev branch of the framework package, too, so yes, the package can be fetched to J4. 2 weeks ago that wasn't the case yet, there it was only in the master branch there.

Merged in the utilities update to 4.0-dev. I haven't taken any time to look through this yet - to be honest there's nothing in here b/c breaking so I'm not going to prioritise this either over the other beta blocking issues - if it has to go to 4.1 - it is what it is. But I will try and do an initial review as well over the next few days and give some opinions.

Export database job plugin:
plg_job_exportdb.zip

This job plugin aims to export the entire database (zip archive) to the defined joomla tmp directory / sub-directory at a defined frequency.

I have tested this item ✅ successfully on 4d0589f

with the export database job plugin.

redone in #29592