Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24890] - [4.0] Move changelog JS to it's own file

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
13 May 2019

Pull Request for Issue #24849

Here goes my first try at some modular JS

Summary of Changes

Fixed the missing modal IDs in the link
Moved all changelog related JavaScript to it's own file

Testing Instructions

  1. Apply this pull request
  2. Run npm run build:js
  3. Install the test extension from https://github.com/roland-d/component_joomla/releases/tag/v0.0.2
  4. Go to Manage
  5. Filter the list on List of Students
  6. Click on the version number 0.0.2
  7. A modal shows up with the changelog as shown below under Manage View
  8. Go to Update
  9. Click on Find Updates
  10. The update is shown and click on the Changelog button
  11. A modal shows up with the changelog as shown below under Update View

Expected result

There is no JavaScript error in Update view
Specific changelog JavaScript is used

Actual result

There is a JavaScript error in Update view
Core Joomla JavaScript is used

Documentation Changes Required

None

Please review:
@euismod2336 @C-Lodder

avatar roland-d roland-d - open - 13 May 2019
avatar roland-d roland-d - change - 13 May 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2019
Category ⇒ Administration com_installer JavaScript Repository NPM Change
avatar roland-d roland-d - change - 13 May 2019
Labels Added: NPM Resource Changed ?
avatar HLeithner HLeithner - change - 14 May 2019
Title
…
Move changelog JS to it's own file
[4.0] Move changelog JS to it's own file
avatar HLeithner HLeithner - edited - 14 May 2019
avatar ghazal
ghazal - comment - 14 May 2019

I have tested this item ✅ successfully on 50951c0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24890.

issue-24890

avatar ghazal ghazal - test_item - 14 May 2019 - Tested successfully
avatar euismod2336
euismod2336 - comment - 17 May 2019

I have tested this item ✅ successfully on 3672c3a

works as advertised

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24890.

avatar euismod2336
euismod2336 - comment - 17 May 2019

I have tested this item ✅ successfully on 3672c3a

works as advertised

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24890.

avatar euismod2336 euismod2336 - test_item - 17 May 2019 - Tested successfully
avatar euismod2336
euismod2336 - comment - 17 May 2019

thnx @roland-d

avatar roland-d
roland-d - comment - 18 May 2019

@ghazal Could you please test again? Thank you.

avatar ghazal
ghazal - comment - 18 May 2019

I have tested this item ✅ successfully on c31d4af

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24890.

avatar ghazal ghazal - test_item - 18 May 2019 - Tested successfully
avatar Quy Quy - change - 18 May 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 18 May 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24890.

avatar roland-d roland-d - change - 18 May 2019
Labels Added: ?
avatar roland-d
roland-d - comment - 30 May 2019

pinging @wilsonge for merge

avatar HLeithner HLeithner - change - 30 May 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-30 12:16:13
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 30 May 2019
avatar HLeithner HLeithner - merge - 30 May 2019
avatar HLeithner
HLeithner - comment - 30 May 2019

thx

avatar roland-d
roland-d - comment - 30 May 2019

Thank you

Add a Comment

Login with GitHub to post a comment