[#24889] - [4.0] Client Selector label
- Fixed in Code Base
- 15 Jul 2019
- Medium
- Build: 4.0-dev
- # 24889
- Diff
- brianteeman:js-stools-field-selector
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
In the following views there is at least one select input in the toolbar. None of them have labels. This PR ensures that each input has a valid label.
com_associations
com_languages&view=overrides
com_languages&view=installed
com_menus
com_templates&view=styles
com_templates&view=templates
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_languages com_menus com_templates Language & Strings Layout |
franz-wohlkoenig
- | Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
?
?
|
||
as always review each pr on their own. if one is merged then the other may need adjusting
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24889.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24889.
conflicts resolved
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24889.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24889.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24889.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24889.
| Labels |
Added:
?
|
||
can this please be merged. I keep going to fix the code and then rememner I already did it
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-15 13:45:12 |
| Closed_By | ⇒ | infograf768 |
tks
Thanks
Updated branch to retrigger drone