[#24875] - [4.0] Port privacy check to es6 js and fix quickicon
- Fixed in Code Base
- 13 May 2019
- Medium
- Build: 4.0-dev
- # 24875
- Diff
- wilsonge:feature/privacy-quickicon
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
To test this ensure the privacy policy quickicon now correctly functions after the patch (before it always hangs on finding requests)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
?
|
||
HLeithner
- | Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24875.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-13 09:10:06 |
| Closed_By | ⇒ | wilsonge |
Thanks JM!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24875.
Please though:
The button View Requests should align to right in LTR and left in RTL,
as it does for Extensions Update.
Text centered.
For extensions:
Also it looks like we have a typo in the .js
langaugeStrings
The wrong alignment of the warning comes from a missing
<div class="message-alert">
as we have for extension update
@infograf768 can you do a PR for that please?
You mean towards yours or a new one?
New one. I already merged this before you posted
argg ;)
I have tested this item✅ successfully on c8557ba
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24875.