? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
12 May 2019
  • Fixes return docblocks
  • Removes unused copy/paste params (and undocumented) from the invalidate function
  • Fix setError to use setMessage (In order to do this I had to fractionally rework the logic in invalidate and invalidateAll when no items were selected - there should be no overall effect on this)
  • Use $this->app instead of the factory application in the controller

Before this patch note many functionalities of requests (such as invalidating requests and deleting items in requests) do not work. After the patch they do.

avatar wilsonge wilsonge - open - 12 May 2019
avatar wilsonge wilsonge - change - 12 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2019
Category Administration
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 May 2019
Title
Clean up controllers in privacy component for j4 related deprecations and features
[4.0] Clean up controllers in privacy component for j4 related deprecations and features
avatar franz-wohlkoenig franz-wohlkoenig - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 13 May 2019

Not sure if it is related but when I try to email a data request I get a 500 error with the following call stack


1 | () | JROOT\libraries\src\Mail\Mail.php:136
-- | -- | --
2 | Joomla\CMS\Mail\Mail->Send() | JROOT\administrator\components\com_privacy\Model\ExportModel.php:238
3 | Joomla\Component\Privacy\Administrator\Model\ExportModel->emailDataExport() | JROOT\administrator\components\com_privacy\Controller\RequestController.php:153
4 | Joomla\Component\Privacy\Administrator\Controller\RequestController->emailexport() | JROOT\libraries\src\MVC\Controller\BaseController.php:736
5 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:146
6 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT\libraries\src\Component\ComponentHelper.php:382
7 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT\libraries\src\Application\AdministratorApplication.php:116
8 | Joomla\CMS\Application\AdministratorApplication->dispatch() | JROOT\libraries\src\Application\AdministratorApplication.php:159
9 | Joomla\CMS\Application\AdministratorApplication->doExecute() | JROOT\libraries\src\Application\CMSApplication.php:241
10 | Joomla\CMS\Application\CMSApplication->execute() | JROOT\administrator\includes\app.php:63
11 | require_once() | JROOT\administrator\index.php:36


avatar wilsonge
wilsonge - comment - 13 May 2019

I don't think so as it's coming from the model email sending. I skipped the email stuff when testing as i was on the train :/ If it's just that mark it as successful and I'll come back to that. At a quick code review I think somethings wrong inside the mailer itself

avatar brianteeman
brianteeman - comment - 13 May 2019

I have tested this item successfully on 735af56

As far as I can tell the changes are good


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24874.

avatar brianteeman brianteeman - test_item - 13 May 2019 - Tested successfully
avatar wilsonge wilsonge - change - 13 May 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-13 12:42:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 May 2019
avatar wilsonge wilsonge - merge - 13 May 2019
avatar wilsonge
wilsonge - comment - 13 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment