? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
12 May 2019

I don't see where this is used anymore, thus removing this. Also because it is not maintained anymore. If the tests don't fail, we can remove this.

avatar Hackwar Hackwar - open - 12 May 2019
avatar Hackwar Hackwar - change - 12 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2019
Category External Library Composer Change
avatar Hackwar Hackwar - change - 12 May 2019
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 12 May 2019

We aren't using them in the limited tests here. We are using it extensively in the integration tests https://github.com/joomla/test-integration

avatar Hackwar
Hackwar - comment - 13 May 2019

We might be using them in the integration tests, but we are not using the integration tests. And since the integration tests are completely and hopelessly broken in 4.0 and need a complete rewrite, we might as well find a better solution then or add it back in. But right now this is just dead code and I'd rather prevent all the questions about "It says we shouldn't use it. Should I remove it?" and the additional download time (as little as that may be).

avatar wilsonge wilsonge - change - 13 May 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-13 09:12:16
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 May 2019
avatar wilsonge wilsonge - merge - 13 May 2019
avatar wilsonge
wilsonge - comment - 13 May 2019

I'm aware that we don't need them here. I'm just saying why they were in the file

Add a Comment

Login with GitHub to post a comment