Feeling Lucky
?
[#24872] - [4.0] Batch button as CE
- Fixed in Code Base
- 13 May 2019
- Medium
- Build: 4.0-dev
- # 24872
- Diff
- brianteeman:batch
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Many of the toolbar buttons use a regular button layout but the majority are using the joomla-toolbar-button element
For consistency and to make styling easier this changes the batch button to use the popup layout instead of the batch layout so that the button uses the custom element.
Partial fix for #24850
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
brianteeman
- comment
- 13 May 2019
yes seems like it
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-13 10:06:41 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 13 May 2019
Perfect - thanks!
brianteeman
- comment
- 13 May 2019
Thanks
From a quick code comparison are we covering the batch button being disabled when no items are selected (i.e. the onclick attribute we have here https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/toolbar/batch.php#L26)