? Pending

User tests: Successful: Unsuccessful:

avatar chandanndeep
chandanndeep
24 Apr 2019

Pull Request for Issue #.

Summary of Changes

This is very helpful. If a user wants to change the typography. He/She can never create the stong CSS selector.

Before selector like this.
.page-header h2 {}
This is not a good selector. If the user changed the h2 tag with other heading tags like h4. In this case, the above selector is not working. But if we add a class with h2 tag. Then it is very helpful. The user creates a strong selector. No matter if h2 tag changed with another heading tags.

Now, the selector will be.
.page-header .item-heading {}

avatar chandanndeep chandanndeep - open - 24 Apr 2019
avatar chandanndeep chandanndeep - change - 24 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2019
Category Layout
avatar brianteeman
brianteeman - comment - 24 Apr 2019

The only way that a user could change from H2 to something else is by creating an override of the layout. So surely they would be able to either add a new class then or just update the CSS.

avatar ReLater
ReLater - comment - 24 Apr 2019

or use something like

.blog .page-header [itemprop="name"]
{
	background-color:green;
}

But I don't know if all browsers support that.

avatar chandanndeep
chandanndeep - comment - 24 Apr 2019

@brianteeman

100% Agree with you.
But some disadvantages of the overrides.

  1. Increase the template size.
  2. If Joomla will change in blog_style_default_item_title.php. Then the user must also do it in the overrides.
  3. Always check the blog_style_default_item_title.php file when he/she can update the Joomla Version.
  4. Time Taken.

Very helpful for developers if Joomla will provide a class with a heading tag

avatar brianteeman
brianteeman - comment - 24 Apr 2019
  1. We have layouts so that you can override things.
  2. With Joomla 4 we have a really cool override check on update now
  3. Its not helpful, because in the scenario you described (changing the h2 to h3) that can only be done in a layout.
avatar chandanndeep
chandanndeep - comment - 24 Apr 2019

@brianteeman
I don't want to change the heading tag from h2 to others. Because the h2 tag is good for SEO.

But the font-size of h2 is 30px but am want to 24px. Now I have no specific class so I can create a strong selector. If I create CSS selector like
.page-header h2 {}
Then this is not a good CSS selector.

So that's why am asking to add the class on heading tag. So the developer can use that class for a CSS selector.

It is helpful. If we do this.

Thanks,
Chandan

avatar chandanndeep
chandanndeep - comment - 26 Apr 2019

@brianteeman

Any update?

avatar brianteeman
brianteeman - comment - 26 Apr 2019

still not convinced

avatar HLeithner
HLeithner - comment - 26 Apr 2019

@chandanndeep @ReLater already should you a solution that does more or less the same as a class.

.blog .page-header [itemprop="name"]
{
	background-color:green;
}

But I don't know if all browsers support that.

this should work for all browser.

avatar chandanndeep chandanndeep - change - 5 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-05 08:28:32
Closed_By chandanndeep
Labels Added: ?
avatar chandanndeep chandanndeep - close - 5 May 2019
avatar chandanndeep
chandanndeep - comment - 5 May 2019

Thanks @brianteeman

Add a Comment

Login with GitHub to post a comment