User tests: Successful: Unsuccessful:
Pull Request for Issue #.
This is very helpful. If a user wants to change the typography. He/She can never create the stong CSS selector.
Before selector like this.
.page-header h2 {}
This is not a good selector. If the user changed the h2 tag with other heading tags like h4. In this case, the above selector is not working. But if we add a class with h2 tag. Then it is very helpful. The user creates a strong selector. No matter if h2 tag changed with another heading tags.
Now, the selector will be.
.page-header .item-heading {}
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
or use something like
.blog .page-header [itemprop="name"]
{
background-color:green;
}
But I don't know if all browsers support that.
100% Agree with you.
But some disadvantages of the overrides.
Very helpful for developers if Joomla will provide a class with a heading tag
@brianteeman
I don't want to change the heading tag from h2 to others. Because the h2 tag is good for SEO.
But the font-size of h2 is 30px but am want to 24px. Now I have no specific class so I can create a strong selector. If I create CSS selector like
.page-header h2 {}
Then this is not a good CSS selector.
So that's why am asking to add the class on heading tag. So the developer can use that class for a CSS selector.
It is helpful. If we do this.
Thanks,
Chandan
Any update?
still not convinced
@chandanndeep @ReLater already should you a solution that does more or less the same as a class.
.blog .page-header [itemprop="name"] { background-color:green; }
But I don't know if all browsers support that.
this should work for all browser.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-05 08:28:32 |
Closed_By | ⇒ | chandanndeep | |
Labels |
Added:
?
|
Thanks @brianteeman
The only way that a user could change from H2 to something else is by creating an override of the layout. So surely they would be able to either add a new class then or just update the CSS.