? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 Apr 2019

With Joomla 3.0, a new set of classes was introduced as a replacement for the old MVC classes. These new classes never gained traction, never were really complete and have been pretty much a failure. The number of extensions that are really build on these classes can most likely be counted on one hand and as far as I know, the JED is one of them. That makes 4 others at max. ? (Since I'm also working on removing UCM as well, JED will need a major overhaul anyway.)

In order to clean up our codebase and stop people from being confused, I'm proposing to remove these classes now and not wait until 5.0.

avatar Hackwar Hackwar - open - 24 Apr 2019
avatar Hackwar Hackwar - change - 24 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2019
Category Administration com_menus com_modules com_workflow Front End com_content com_newsfeeds Libraries
avatar Hackwar
Hackwar - comment - 24 Apr 2019

#24715 contains the changes to deprecate it already for 4.0.

avatar mbabker
mbabker - comment - 24 Apr 2019

[removed by @mbabker]

avatar Hackwar
Hackwar - comment - 24 Apr 2019

That is the nice thing about opinions. Everybody is allowed to have their own.

Developers, site owners, everybody involved will have a phase of about 2.5 years to get his code updated from 3.9 to 4.0. I expect deprecations to happen until beta and nothing after that. But from beta to release, I expect that to take about half a year, plus the 2 years that we will support 3.10 from then onward. That is enough time in my book. It actually makes me angry that you argued with the same argument of to short of a notice about this almost 2 years ago, which would have made the whole timeframe something about 4 years until people really shouldn't use 3.x anymore. I'm fed up with those discussions "Which of the 4 MVCs ("new", legacy, namespaced, fof) should I use now? I'm confused." If you want to moan about late deprecations during development, have a look at my other PRs. I'm working on removing UCM, rewriting tagging and versioning as well.

I see no reason why we should keep these classes in 4.x, especially since there are rumours that we should introduce yet another new MVC in 4.1/2/3/4/whatever as well.

avatar mbabker
mbabker - comment - 24 Apr 2019

[removed by @mbabker]

avatar Hackwar
Hackwar - comment - 24 Apr 2019

I just looked at https://semver.org/ and that contains no requirement to deprecate X versions before removal. It just says to bump the minor version (which we are doing with 3.10) and semver requires us to bump the major version when doing a breaking change, which we do with 4.0.

And it is a matter of calendar days. Or do you want to tell me, that if we pushed another major verison between 3.10 and what is currently known as 4.0, everything would be fine? It is always a question of real, actual time. In terms of financial investment into a site, Joomla has been pretty stable for a freakingly long time. Code from 1.6 still runs on 3.9. We also promised website owners a grace period of 2 years after the last minor release of a series to slowly get their sites switched over. You don't get such long support for a commercial Android phone. It is a reasonable transition period and the arguments for giving people longer time do not outweigh the issues of being stuck for another 5-10 years with this code for me.

avatar Hackwar
Hackwar - comment - 24 Apr 2019

And about the stemmer: Contrary to popular believe, not everything centers around the anglo-centric world. About 6 billion of us don't speak english as their first language and couldn't care less if an english-only stemmer is removed or not. The deprecation notice actually names a library that is as near a drop-in replacement for that code as I dare to propose AND which has the benefit of supporting languages for about 2 billion people. Again a trade-of that I'm happy to make.

avatar mbabker
mbabker - comment - 24 Apr 2019

You know, I actually had a decent reply written up, but I've decided to delete it and I'm just going to unsubscribe from the relevant PRs because all this is doing is making my blood pressure elevated, especially after the quip about being English focused (if I were really that egotistic I would have never been the one to propose the issue tracker support translations in the first place and I would've kept MAT and Sandra from doing translation support on the downloads site, just because I'm American doesn't mean I'm as narcissistic as the orange monkey residing in the White House).

Look, I have no problem with the deprecations. I don't agree with short notice deprecations without strong reasoning (i.e. security issues), and that is exactly what I think these PRs represent.

avatar Bakual
Bakual - comment - 24 Apr 2019

We already deprecated those classes with 3.9.0 and set removal for 5.0.
It's a very bad sign if we now change the removal date with 3.10.0. Especially since 3.10.0 is expected to be released at the same time as 4.0.0. And especially since there is no easy way to adjust the extension.
It's a sure way to piss off extension developers who relied on those classes.

And no, there are not 2.5 years to get code updated. Those 2.5 are the time people have to upgrade their site, not the time developers have to update their extensions. Those should be ready shorty after 4.0.0 is released since people will want to upgrade.

avatar Hackwar Hackwar - change - 26 Apr 2019
Labels Added: ?
avatar richard67
richard67 - comment - 28 Jul 2019

@Hackwar Still wanna leave this open after feedback as above?

avatar Hackwar
Hackwar - comment - 28 Jul 2019

yes

avatar richard67
richard67 - comment - 28 Jul 2019

Maybe George should decide?

avatar Hackwar
Hackwar - comment - 28 Jul 2019

I'd like to bring this to the attention of the PLT and hear their opinions. Of course George has the final say in this.

avatar richard67
richard67 - comment - 28 Jul 2019

When you discuss then please mention also the concerns Michael had and that he will block installation of the Patchtester on J4 when this is merged.

avatar alikon
alikon - comment - 7 Dec 2019

can we close this one as originally planned for 5.x ?
@Hackwar

avatar Hackwar
Hackwar - comment - 7 Dec 2019

Yes, closing this one. This wont be relevant before 5.0, unfortunately.

avatar Hackwar Hackwar - change - 7 Dec 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-12-07 12:29:35
Closed_By Hackwar
avatar Hackwar Hackwar - close - 7 Dec 2019

Add a Comment

Login with GitHub to post a comment